Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpful error when constant not found #6146

Conversation

paulcsmith
Copy link
Contributor

@paulcsmith paulcsmith commented May 31, 2018

Closes #6122

screen shot 2018-05-30 at 9 51 40 pm

@paulcsmith
Copy link
Contributor Author

A few failing specs where I need to use the contains matcher to handle the new error messages. Will tackle that sometime this week

Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to add specs for the behaviour added in this PR!


Try this...

▸ Require the file with #{type.program.colorize(self).bold}. For example: #{colorized_require_example}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file with Foo seems a bit imprecise. What about the file that defines Foo?
Or, more similar to the second suggestion:

If Foo is declared in a file, add a relative require require "./foo"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion 👍

@paulcsmith
Copy link
Contributor Author

I have been working on some other stuff with Lucky, but I'll come back to this PR this week (hopefully!).

@j8r
Copy link
Contributor

j8r commented Dec 20, 2018

@paulcsmith what a long week 😄 Have you the time to continue on this?

@straight-shoota straight-shoota added kind:feature topic:compiler pr:needs-work A PR requires modifications by the author. labels Feb 11, 2019
@straight-shoota
Copy link
Member

Closing stale PR. There has been no activity for a long time and there's no point in keeping this open.
The feature enhancement is still tracked in #6122.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature pr:needs-work A PR requires modifications by the author. topic:compiler
Projects
None yet
3 participants