Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spectral-cube: init at 0.4.2 #41168

Merged
merged 3 commits into from May 30, 2018
Merged

spectral-cube: init at 0.4.2 #41168

merged 3 commits into from May 30, 2018

Conversation

smaret
Copy link
Member

@smaret smaret commented May 28, 2018

Motivation for this change

This PR provides a package forspectral-cube, a Python module for reading and analyzing astrophysical spectral data cubes. It also provides a package for radio_beam, on which spectral-cube depends.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@smaret smaret requested a review from FRidh as a code owner May 28, 2018 11:10
FRidh
FRidh requested changes May 28, 2018
View reviewed changes
pkgs/development/python-modules/radio_beam/default.nix Outdated
pname = "radio_beam";
version = "0.2";

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the tests disabled? Include a comment in the expression explaining why the tests are disabled.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests require several pytest plugins that are not in nixpkgs. I've added a comment in the expressions.

pkgs/development/python-modules/spectral-cube/default.nix Outdated
pname = "spectral-cube";
version = "0.4.3";

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the tests disabled? Include a comment in the expression explaining why the tests are disabled.

@FRidh
Copy link
Member

FRidh commented May 28, 2018

@GrahamcOfBorg build python2.pkgs.spectral-cube python3.pkgs.spectral-cube python2.pkgs.radio_cube python3.pkgs.radio_cube

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.spectral-cube

The following builds were skipped because they don't evaluate on aarch64-linux: python2.pkgs.spectral-cube, python2.pkgs.radio_cube, python3.pkgs.radio_cube

Partial log (click to expand)

Installing collected packages: spectral-cube
Successfully installed spectral-cube-0.4.3
/build/spectral-cube-0.4.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rgf5a54c7n6xzdx475djfw6vl8izxdqa-python3.6-spectral-cube-0.4.3
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rgf5a54c7n6xzdx475djfw6vl8izxdqa-python3.6-spectral-cube-0.4.3/lib
patching script interpreter paths in /nix/store/rgf5a54c7n6xzdx475djfw6vl8izxdqa-python3.6-spectral-cube-0.4.3
checking for references to /build in /nix/store/rgf5a54c7n6xzdx475djfw6vl8izxdqa-python3.6-spectral-cube-0.4.3...
/nix/store/rgf5a54c7n6xzdx475djfw6vl8izxdqa-python3.6-spectral-cube-0.4.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.spectral-cube

The following builds were skipped because they don't evaluate on x86_64-linux: python2.pkgs.spectral-cube, python2.pkgs.radio_cube, python3.pkgs.radio_cube

Partial log (click to expand)

Requirement already satisfied: astropy in /nix/store/wykb8yl02wny74hzvx71qv69pc0hf3c2-python3.6-astropy-3.0.2/lib/python3.6/site-packages (from spectral-cube==0.4.3) (3.0.2)
Installing collected packages: spectral-cube
Successfully installed spectral-cube-0.4.3
/build/spectral-cube-0.4.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xhvfcqh4sijws02hi32m5xy87q154j57-python3.6-spectral-cube-0.4.3
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xhvfcqh4sijws02hi32m5xy87q154j57-python3.6-spectral-cube-0.4.3/lib
patching script interpreter paths in /nix/store/xhvfcqh4sijws02hi32m5xy87q154j57-python3.6-spectral-cube-0.4.3
checking for references to /build in /nix/store/xhvfcqh4sijws02hi32m5xy87q154j57-python3.6-spectral-cube-0.4.3...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3.pkgs.spectral-cube

The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.spectral-cube, python2.pkgs.radio_cube, python3.pkgs.radio_cube

Partial log (click to expand)

Requirement already satisfied: radio-beam in /nix/store/5ymkwd33nz6m61f5r7a52qinvcyhb6dn-python3.6-radio_beam-0.2/lib/python3.6/site-packages (from spectral-cube==0.4.3) (0.2)
Requirement already satisfied: astropy in /nix/store/ign6q89hvrphxlwlj6z0q9sdlzacv1zp-python3.6-astropy-3.0.2/lib/python3.6/site-packages (from spectral-cube==0.4.3) (3.0.2)
Requirement already satisfied: numpy>=1.8.0 in /nix/store/5r08b4fpis5113xbfy0pzpgmw5ympj0m-python3.6-numpy-1.14.3/lib/python3.6/site-packages (from spectral-cube==0.4.3) (1.14.3)
Installing collected packages: spectral-cube
Successfully installed spectral-cube-0.4.3
/private/tmp/nix-build-python3.6-spectral-cube-0.4.3.drv-0/spectral-cube-0.4.3
post-installation fixup
strip is /nix/store/r5mcn9vqq80v5pfqp45d7290cis7dwp4-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/j271xr6i9wmcyzd71pw3wcln9i14mw3q-python3.6-spectral-cube-0.4.3/lib
patching script interpreter paths in /nix/store/j271xr6i9wmcyzd71pw3wcln9i14mw3q-python3.6-spectral-cube-0.4.3

@smaret
Copy link
Member Author

smaret commented May 30, 2018

@FRidh Thanks for the review. I've made the changes you requested and I've pushed the commits into my branch (with the --force option). This is perhaps why the "Changes requested" tag still appears in this PR.

@FRidh
Copy link
Member

FRidh commented May 30, 2018

Thanks.

@FRidh FRidh merged commit 11a2d07 into NixOS:master May 30, 2018
@smaret smaret deleted the spectral-cube branch May 30, 2018 08:20
@smaret smaret mentioned this pull request May 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smaret @FRidh @GrahamcOfBorg @Janik-Haag