Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noto-fonts: separate package for unusual weights #41184

Merged
merged 1 commit into from May 29, 2018
Merged

noto-fonts: separate package for unusual weights #41184

merged 1 commit into from May 29, 2018

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented May 28, 2018 •
edited

Motivation

Noto provides a large number of unusual font weights so that the complete
package of fonts is more than 300 MB in size. Most of these weights are moved
into noto-fonts-extra; noto-fonts retains the ordinary weights and styles.

See also: #31543

Testing

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel
noto-fonts: separate package for unusual weights
8f43bb4 
Noto provides a large number of unusual font weights so that the complete
package of fonts is more than 300 MB in size. Most of these weights are moved
into noto-fonts-extra; noto-fonts retains the ordinary weights and styles.

See also: NixOS#31543
@ttuegel ttuegel self-assigned this May 28, 2018
@ttuegel ttuegel requested a review from benley May 28, 2018 18:16
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: noto-fonts

Partial log (click to expand)

  noto-fonts-2017-10-24-phase3-second-cleanup/alpha/LICENSE -> ../LICENSE
lchmod (file attributes) error: Function not implemented
  noto-fonts-2017-10-24-phase3-second-cleanup/hinted/COPYING -> ../LICENSE
lchmod (file attributes) error: Function not implemented
  noto-fonts-2017-10-24-phase3-second-cleanup/hinted/LICENSE -> ../LICENSE
lchmod (file attributes) error: Function not implemented
  noto-fonts-2017-10-24-phase3-second-cleanup/unhinted/COPYING -> ../LICENSE
lchmod (file attributes) error: Function not implemented
  noto-fonts-2017-10-24-phase3-second-cleanup/unhinted/LICENSE -> ../LICENSE
lchmod (file attributes) error: Function not implemented

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: noto-fonts

Partial log (click to expand)

  noto-fonts-2017-10-24-phase3-second-cleanup/alpha/LICENSE -> ../LICENSE
lchmod (file attributes) error: Function not implemented
  noto-fonts-2017-10-24-phase3-second-cleanup/hinted/COPYING -> ../LICENSE
lchmod (file attributes) error: Function not implemented
  noto-fonts-2017-10-24-phase3-second-cleanup/hinted/LICENSE -> ../LICENSE
lchmod (file attributes) error: Function not implemented
  noto-fonts-2017-10-24-phase3-second-cleanup/unhinted/COPYING -> ../LICENSE
lchmod (file attributes) error: Function not implemented
  noto-fonts-2017-10-24-phase3-second-cleanup/unhinted/LICENSE -> ../LICENSE
lchmod (file attributes) error: Function not implemented

@ttuegel ttuegel merged commit 7b62752 into NixOS:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benley benley Awaiting requested review from benley

Assignees

@ttuegel ttuegel

Labels
6.topic: closure-size 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttuegel @GrahamcOfBorg