Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgdiplus: fix build #41187

Merged
merged 1 commit into from May 29, 2018
Merged

libgdiplus: fix build #41187

merged 1 commit into from May 29, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented May 28, 2018

Motivation for this change

libgdiplus was broken after b22cc53

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
libgdiplus: fix build
98a4fbf 
was broken after b22cc53
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libgdiplus

Partial log (click to expand)

make[1]: Leaving directory '/build/libgdiplus-2.10.9'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0vam0fg286lx4379dz67ni7hd269360q-libgdiplus-2.10.9
shrinking /nix/store/0vam0fg286lx4379dz67ni7hd269360q-libgdiplus-2.10.9/lib/libgdiplus.so.0.0.0
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0vam0fg286lx4379dz67ni7hd269360q-libgdiplus-2.10.9/lib
patching script interpreter paths in /nix/store/0vam0fg286lx4379dz67ni7hd269360q-libgdiplus-2.10.9
checking for references to /build in /nix/store/0vam0fg286lx4379dz67ni7hd269360q-libgdiplus-2.10.9...
/nix/store/0vam0fg286lx4379dz67ni7hd269360q-libgdiplus-2.10.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libgdiplus

Partial log (click to expand)

make[1]: Leaving directory '/build/libgdiplus-2.10.9'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g2ws2p2qggz29l3m9klymln4i67k2ch4-libgdiplus-2.10.9
shrinking /nix/store/g2ws2p2qggz29l3m9klymln4i67k2ch4-libgdiplus-2.10.9/lib/libgdiplus.so.0.0.0
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g2ws2p2qggz29l3m9klymln4i67k2ch4-libgdiplus-2.10.9/lib
patching script interpreter paths in /nix/store/g2ws2p2qggz29l3m9klymln4i67k2ch4-libgdiplus-2.10.9
checking for references to /build in /nix/store/g2ws2p2qggz29l3m9klymln4i67k2ch4-libgdiplus-2.10.9...
/nix/store/g2ws2p2qggz29l3m9klymln4i67k2ch4-libgdiplus-2.10.9

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libgdiplus

Partial log (click to expand)

/nix/store/489fpf6pzj12gkh8xp89qh00m6brnj15-libgdiplus-2.10.9/lib/libgdiplus.0.dylib: fixing dylib
/nix/store/489fpf6pzj12gkh8xp89qh00m6brnj15-libgdiplus-2.10.9/lib/libgdiplus.0.dylib: fixing dylib
/nix/store/489fpf6pzj12gkh8xp89qh00m6brnj15-libgdiplus-2.10.9/lib/libgdiplus.0.dylib: fixing dylib
/nix/store/489fpf6pzj12gkh8xp89qh00m6brnj15-libgdiplus-2.10.9/lib/libgdiplus.0.dylib: fixing dylib
/nix/store/489fpf6pzj12gkh8xp89qh00m6brnj15-libgdiplus-2.10.9/lib/libgdiplus.0.dylib: fixing dylib
/nix/store/489fpf6pzj12gkh8xp89qh00m6brnj15-libgdiplus-2.10.9/lib/libgdiplus.0.dylib: fixing dylib
/nix/store/489fpf6pzj12gkh8xp89qh00m6brnj15-libgdiplus-2.10.9/lib/libgdiplus.0.dylib: fixing dylib
/nix/store/489fpf6pzj12gkh8xp89qh00m6brnj15-libgdiplus-2.10.9/lib/libgdiplus.0.dylib: fixing dylib
/nix/store/489fpf6pzj12gkh8xp89qh00m6brnj15-libgdiplus-2.10.9/lib/libgdiplus.0.dylib: fixing dylib
/nix/store/489fpf6pzj12gkh8xp89qh00m6brnj15-libgdiplus-2.10.9

This was referenced May 28, 2018
Merged
Merged
@LnL7 LnL7 merged commit 437b98c into NixOS:master May 29, 2018
@xeji xeji deleted the p/libgdiplus branch May 29, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @LnL7