Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminus: gnome2 cleanup #41173

Merged
merged 2 commits into from May 30, 2018
Merged

terminus: gnome2 cleanup #41173

merged 2 commits into from May 30, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Removed/updated gnome2 references (Part of #39976).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented May 28, 2018

#41174 (comment) applies here as well. Hmm, we could really use mkElectronDerivation function to stop repeating ourselves.

@worldofpeace
Copy link
Contributor Author

we could really use mkElectronDerivation function to stop repeating ourselves.

Ahh music too my ears. They are way too many expressions that look just like this one.

jtojnar
jtojnar reviewed May 29, 2018
View reviewed changes
pkgs/applications/misc/terminus/default.nix Outdated

let
libPath = stdenv.lib.makeLibraryPath [
stdenv.cc.cc gtk2 atk glib pango gdk_pixbuf cairo freetype fontconfig dbus
stdenv.cc.cc gnome3.gtk2 atk glib pango gdk_pixbuf cairo freetype fontconfig dbus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use top-level gtk2.

@worldofpeace
Copy link
Contributor Author

@xeji There's this one too. Next time I try to make similar changes it'll be one pr 👍

@xeji
Copy link
Contributor

xeji commented May 30, 2018

@GrahamcOfBorg build terminus

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: terminus

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: terminus

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: terminus

Partial log (click to expand)

strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x3vsr9gxzrg55qxxximdfsj50qrqz5vf-terminus-1.0.0-alpha.42/bin
patching script interpreter paths in /nix/store/x3vsr9gxzrg55qxxximdfsj50qrqz5vf-terminus-1.0.0-alpha.42
/nix/store/x3vsr9gxzrg55qxxximdfsj50qrqz5vf-terminus-1.0.0-alpha.42/opt/Terminus/resources/builtin-plugins/terminus-terminal/node_modules/nan/doc/.build.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/m47apl3hq3i52fzy2cz24378p0xn4lyx-bash-4.4-p19/bin/bash"
head: error writing 'standard output': Broken pipe
checking for references to /build in /nix/store/x3vsr9gxzrg55qxxximdfsj50qrqz5vf-terminus-1.0.0-alpha.42...
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/x3vsr9gxzrg55qxxximdfsj50qrqz5vf-terminus-1.0.0-alpha.42

@xeji
Copy link
Contributor

xeji commented May 30, 2018

199MB disk size (this package alone, not the closure) for a simple terminal program, including a 74MB executable blob. We cannot build it from source because it would be too complicated.
And some people call that modern software ☹️

@xeji xeji merged commit 9149942 into NixOS:master May 30, 2018
@worldofpeace worldofpeace deleted the terminus-nognome2 branch May 30, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @jtojnar @xeji @GrahamcOfBorg