Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
vdt: Tidy up Portfile, removing unneccessary parts.
  • Loading branch information
cjones051073 committed Jun 15, 2018
1 parent c1ffc92 commit 5b124d9
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions math/vdt/Portfile
Expand Up @@ -4,22 +4,18 @@ PortSystem 1.0

PortGroup active_variants 1.1
PortGroup cmake 1.0
#PortGroup compiler_blacklist_versions 1.0
PortGroup github 1.0
PortGroup xcodeversion 1.0
PortGroup cxx11 1.1

#github.setup dpiparo vdt 0.4.1 v
#version [string map {- .} ${github.version}]
#revision 0
#livecheck.version ${github.version}
# Use git commit
github.setup cjones051073 vdt b376d0f9e8cc97689d89f7f8c40c3a4644f48679

This comment has been minimized.

Copy link
@l2dy

l2dy Jun 16, 2018

Member

The checksums can ensure reproducibility. Any particular reason to use git commit? Automatic livecheck checks for newest master commit if you use a specific commit in github.setup.

This comment has been minimized.

Copy link
@cjones051073

cjones051073 Jun 16, 2018

Author Member

I am using a commit instead of a tag as I had to make a small fix for OSX 10.11 that is not (yet) in the main repo. That also why i am using my fork.

This comment has been minimized.

Copy link
@l2dy

l2dy Jun 16, 2018

Member

In that case please use patchfiles (https://guide.macports.org/#development.patches.source). We generally discourage using personal forks for small patches.

This comment has been minimized.

Copy link
@pmetzger

pmetzger Jun 16, 2018

Member

Generally, I strongly recommend doing pull requests so people can review changes unless you are very confident no one will have any interesting input to give you.

This comment has been minimized.

Copy link
@cjones051073

cjones051073 Jun 16, 2018

Author Member

As I have already said, i agree I should have used a PR in the first instance when submitting the new port. My mistake. However as this commit was just making changes already suggested i felt a PR was then unnecessary.

This comment has been minimized.

Copy link
@ryandesign

ryandesign Jul 28, 2018

Contributor

a small fix for OSX 10.11 that is not (yet) in the main repo

Have you reported this to the developers? I didn't find an upstream issue or PR for it.

This comment has been minimized.

Copy link
@cjones051073

cjones051073 Jul 28, 2018

Author Member

No, not yet. The fix I deployed is not yet ready to be sent upstream. I need to do some work to figure out what exactly the problem is, and why it only affects 10.11. I just haven't gotten around to it yet...

version 0.4.1
revision 1

homepage https://github.com/dpiparo/vdt

checksums rmd160 c7a81e43a98f9c19738895e66a3dfc61b9fe1d10 \
sha256 f022942d2359744ca17935ef65c942c4631c2908123b8fb2f436f281a7b59f10 \
size 59664
Expand All @@ -33,16 +29,3 @@ description A collection of fast and inline implementations of mathemati
long_description ${name} provides ${description}.

platforms darwin

#depends_lib
#depends_run port:root_select

# Force a compatible compiler
#compiler.blacklist-append *gcc* {clang < 900} macports-clang-3.3 macports-clang-3.4 \
# macports-clang-3.5 macports-clang-3.6 macports-clang-3.7 \
# macports-clang-3.8
#compiler.whitelist clang macports-clang-5.0 macports-clang-4.0 macports-clang-3.9

livecheck.type regex
livecheck.url ${github.homepage}/tags
livecheck.regex {archive/v([0-9.]+).tar.gz}

0 comments on commit 5b124d9

Please sign in to comment.