Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d8ff206ccb79^
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d4894cd6ee28
Choose a head ref
  • 8 commits
  • 17 files changed
  • 1 contributor

Commits on Jun 15, 2018

  1. [refactor] hide (JRuby) internal Process constants

    @kares
    kares committed Jun 15, 2018
    Copy the full SHA
    d8ff206 View commit details

  2. [refactor] remove deprecated thread local - use one field

    @kares
    kares committed Jun 15, 2018
    Copy the full SHA
    6cc8d8c View commit details

  3. [test] avoid rspec warnings on raise_error

    @kares
    kares committed Jun 15, 2018
    Copy the full SHA
    4a8d786 View commit details

  4. [ji] let's not remove duplicate methods from hierarchy 

    e.g. previously a instance_method(:toString) would only exists on
java.lang.Object - custom impls in more concrete classes would not show
up. which is fine to save space due Java's dispatch rules but the proxy
class hierarachy doesn't match reality which we'll need for Java inspect
-> toString
    @kares
    kares committed Jun 15, 2018
    Copy the full SHA
    9a61747 View commit details

  5. [ji] inspect for Java proxies -> toString or a custom fallback 

    need a base to_s impl on java.lang.Object - calling toString()
refactored the Java object proxy class tracking in JavaSupport
    @kares
    kares committed Jun 15, 2018
    Copy the full SHA
    2320e67 View commit details

  6. [test] split and adjust Hash-like expectations 

    inspect/to_s are expected to behave like rest of Java proxies
(delegating to String) while also Java APIs should always win when
there's a conflict in naming e.g. Map#clear vs Hash#clear
    @kares
    kares committed Jun 15, 2018
    Copy the full SHA
    8ca307b View commit details

  7. [test] JI spec how inspect -> toString 

    this would be a resolution for weird non-readable rspec output
... with Java types - GH-5182
    @kares
    kares committed Jun 15, 2018
    Copy the full SHA
    37f78d4 View commit details

  8. revert reflective inspect for now 

    ... as there are a few 'uniformity' pieces to figure out
    @kares
    kares committed Jun 15, 2018
    Copy the full SHA
    d4894cd View commit details
Loading