Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: anbox: Init #42076

Closed
wants to merge 7 commits into from
Closed

WIP: anbox: Init #42076

wants to merge 7 commits into from

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Jun 15, 2018

Motivation for this change

Based on the work of @volth and @Mic92.

Currently its missing networking support. I would like to integrate that before merging this pull request.
I'm open for feedback.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bkchr
Copy link
Contributor Author

bkchr commented Jun 15, 2018

Yeah, I saw that, but as he stopped working on it, I did not mention it.

truncate -s 0 cmake/FindGMock.cmake
truncate -s 0 tests/CMakeLists.txt

substituteInPlace scripts/gen-emugl-entries.py --replace '/usr/bin/env python2' "${python2}/bin/python"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patchShebangs is the preferred way here.

StartServiceByName "su" org.anbox 0

$out/bin/anbox launch --package=org.anbox.appmgr --component=org.anbox.appmgr.AppViewActivity
EOF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use makeWrapper both scripts here. It also has a --run parameter for the busctl command.

buildInputs = [
boost SDL2 mesa_glu glm protobuf dbus-cpp lxc
gtest xorg.libpthreadstubs xorg.libXdmcp SDL2_image
makeWrapper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeWrapper belongs to nativeBuildInputs.

@jameysharp
Copy link
Contributor

@bkchr Did you close your PR because you want somebody else to pick up the work, or do you have some reason to believe this shouldn't be packaged? Either way it'd be helpful to record your thoughts for the next person who's interested (possibly me, but no promises).

@bkchr
Copy link
Contributor Author

bkchr commented Sep 6, 2018

I'm open to anyone that wants to continue this work. I just not require this anymore and do not have the time to bring it to the end. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants