Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping dhall #41404

Closed
wants to merge 1 commit into from
Closed

Conversation

blast-hardcheese
Copy link

Motivation for this change

There's a new feature in dhall-json that permits a wide variety of use cases (see dhall-lang/dhall-json#27 )

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I'm unsure how to test this, but I'm willing to do the work. I was unable to find consistent documentation other than some references to "Hydra just builds things automatically".

New language features and language clarifications over the past few
months means the behaviour of these packages when installed from
source/homebrew is significantly different than what's available in Nix.
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those versions are based on LTS Haskell https://www.stackage.org/lts-11.11 and I don't want to deviate from upstream because that change will likely affect other builds.

@peti peti closed this Jun 3, 2018
@blast-hardcheese blast-hardcheese deleted the bump-dhall branch June 3, 2018 19:28
@blast-hardcheese
Copy link
Author

understood -- that was not clear from the documentation, though I've seen your PRs updating the LTS version. I expect as the package is tracked in the nightlies, it'll migrate its way into LTS automatically?

@peti
Copy link
Member

peti commented Jun 4, 2018

https://github.com/commercialhaskell/lts-haskell#readme has all the information you'll need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants