ctags: fix source url #41382
Merged
ctags: fix source url #41382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream SVN appears to no longer exist: ``` svn: E170013: Unable to connect to a repository at URL 'https://ctags.svn.sourceforge.net/svnroot/ctags/trunk' svn: E160013: '/svnroot/ctags/trunk' path not found ``` The download homepage just references the sourceforge download: http://ctags.sourceforge.net/ which is version 5.8.
bhipple
commented
Jun 2, 2018
| # don't use $T(E)MP which is set to the build directory | ||
| configureFlags= [ "--enable-tmpdir=/tmp" ]; | ||
| # lregex.c:411:4: error: format not a string literal and no format arguments [-Werror=format-security] | ||
| hardeningDisable = [ "format" ]; |
There was a problem hiding this comment.
I don't know what the difference between this version and whatever they had in their (deco'd?) SVN repository is, but this one appears to not need the configure flag, although it does need the hardening flag.
There was a problem hiding this comment.
I don't think we should make this change. The latest available release (816, which we have now) is from 2014, this PR downgrades to a 2009 version (IIRC, with some CVE vulnerabilities). The 816 code is still there at https://sourceforge.net/p/ctags/code/HEAD/tree/trunk/ .
|
@GrahamcOfBorg build ctags |
|
Success on x86_64-linux (full log) Attempted: ctags Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ctags Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ctags Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: ctags Partial log (click to expand)
|
xeji
suggested changes
Jun 2, 2018
| # don't use $T(E)MP which is set to the build directory | ||
| configureFlags= [ "--enable-tmpdir=/tmp" ]; | ||
| # lregex.c:411:4: error: format not a string literal and no format arguments [-Werror=format-security] | ||
| hardeningDisable = [ "format" ]; |
There was a problem hiding this comment.
I don't think we should make this change. The latest available release (816, which we have now) is from 2014, this PR downgrades to a 2009 version (IIRC, with some CVE vulnerabilities). The 816 code is still there at https://sourceforge.net/p/ctags/code/HEAD/tree/trunk/ .
|
Update: just change the fetchsvn url to |
|
Ah thanks @xeji! I'm glad we can just swap to a moved URL instead of downgrading to the "official" release, which appears semi-abandonded. |
|
Success on x86_64-linux (full log) Attempted: ctags Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ctags Partial log (click to expand)
|
xeji
approved these changes
Jun 3, 2018
orivej
added a commit
that referenced
this pull request
Jun 4, 2018
* master: (26 commits) python.pkgs.cairocffi: update tests for Cairo 1.15.12 python.pkgs.cairocffi: 0.8.0 -> 0.8.1 freecell-solver: fix build perlPackages.CPANPLUS: restore build inputs removed in #41394 Fix GHCJS 8.4/8.2 in sandboxed builds (#41411) dockerTools.pullImage: expose image* attributes (#41366) rust: disable tests on darwin python.pkgs.detox: 0.11 -> 0.12 certbot: disable check on darwin freeimage: fix build with glibc 2.27 shadowsocks-libev: supports darwin (#41421) pythonPackages.jira: fix build (#41419) SDL: propagate libiconv schema2ldif: Init at 1.3 nixos/exim: Add unit restart trigger (#41418) Add myself as maintainer for dnsdist Add myself as maintainer synapse-bt: init at 2018-06-04 (#41402) skim: 0.3.2 -> 0.4.0 (#41417) ctags: fix source url (#41382) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream SVN appears to no longer exist:
The download homepage just references the sourceforge download:
http://ctags.sourceforge.net/
which is version 5.8.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)