Disable hfscompression for non-root installs

Due to a bug in bsdtar, xattrs fail to be restored for read-only files. Being root naturally circumvents this problem. See: https://trac.macports.org/ticket/56563
macports · Jun 1, 2018 · cf91a8b · cf91a8b
1 parent feaba00
commit cf91a8b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/registry2.0/portimage.tcl b/src/registry2.0/portimage.tcl
@@ -353,7 +353,8 @@ proc extract_archive_to_tmpdir {location} {
                 global macports::hfscompression
                 # Opportunistic HFS compression. bsdtar will automatically
                 # disable this if filesystem does not support compression.
-                if {${macports::hfscompression} &&
+                # Have to be root due to <https://trac.macports.org/ticket/56563>.
+                if {${macports::hfscompression} && [getuid] == 0 &&
                         ![catch {macports::binaryInPath bsdtar}] &&
                         ![catch {exec bsdtar -x --hfsCompression < /dev/null >& /dev/null}]} {
                     ui_debug "Using bsdtar with HFS+ compression (if valid)"