Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bulletml: fix build failure due to -Wformat-security #41387

Merged
merged 1 commit into from Jun 2, 2018
Merged

bulletml: fix build failure due to -Wformat-security #41387

merged 1 commit into from Jun 2, 2018

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jun 2, 2018 •
edited

Motivation for this change

Some files are built with -Wno-format, which is not compatible with the
default hardening setting of -Wformat-security in Nixpkgs.

I forgot to rebuild after rebase in the last pr, so bulletml got merged in a broken state.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fgaz
bulletml: fix build failure due to -Wformat-security
ab2c15e 
Some files are built with -Wno-format, which is not compatible with the
default hardening setting of -Wformat-security in Nixpkgs.
@xeji
Copy link
Contributor

xeji commented Jun 2, 2018

@GrahamcOfBorg build bulletml

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bulletml

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yhggv6plpayrkggh2nginjgsdmcnhs6l-bulletml-0.0.6
shrinking /nix/store/yhggv6plpayrkggh2nginjgsdmcnhs6l-bulletml-0.0.6/lib/libbulletml.so
shrinking /nix/store/yhggv6plpayrkggh2nginjgsdmcnhs6l-bulletml-0.0.6/lib/libbulletml.so.0d2
shrinking /nix/store/yhggv6plpayrkggh2nginjgsdmcnhs6l-bulletml-0.0.6/lib/libbulletml.so.0d2.0
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yhggv6plpayrkggh2nginjgsdmcnhs6l-bulletml-0.0.6/lib
patching script interpreter paths in /nix/store/yhggv6plpayrkggh2nginjgsdmcnhs6l-bulletml-0.0.6
checking for references to /build in /nix/store/yhggv6plpayrkggh2nginjgsdmcnhs6l-bulletml-0.0.6...
/nix/store/yhggv6plpayrkggh2nginjgsdmcnhs6l-bulletml-0.0.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bulletml

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xvrw0jghmj2flv97qsyipjdzhardinnx-bulletml-0.0.6
shrinking /nix/store/xvrw0jghmj2flv97qsyipjdzhardinnx-bulletml-0.0.6/lib/libbulletml.so.0d2.0
shrinking /nix/store/xvrw0jghmj2flv97qsyipjdzhardinnx-bulletml-0.0.6/lib/libbulletml.so.0d2
shrinking /nix/store/xvrw0jghmj2flv97qsyipjdzhardinnx-bulletml-0.0.6/lib/libbulletml.so
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xvrw0jghmj2flv97qsyipjdzhardinnx-bulletml-0.0.6/lib
patching script interpreter paths in /nix/store/xvrw0jghmj2flv97qsyipjdzhardinnx-bulletml-0.0.6
checking for references to /build in /nix/store/xvrw0jghmj2flv97qsyipjdzhardinnx-bulletml-0.0.6...
/nix/store/xvrw0jghmj2flv97qsyipjdzhardinnx-bulletml-0.0.6

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bulletml

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji xeji merged commit 799a461 into NixOS:master Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @xeji @GrahamcOfBorg