Make zig fmt exit with error on any parse errors

tiehuis · tiehuis · commit e514454c0e09 · 2018-06-02T20:49:35.000+12:00
This is required for proper detection in editor plugins. Other files may
have been formatted correctly, this only indicates that some failed.
diff --git a/src-self-hosted/main.zig b/src-self-hosted/main.zig
@@ -728,18 +728,21 @@ fn cmdFmt(allocator: *Allocator, args: []const []const u8) !void {
         }
     };
 
+    var fmt_errors = false;
     for (flags.positionals.toSliceConst()) |file_path| {
         var file = try os.File.openRead(allocator, file_path);
         defer file.close();
 
         const source_code = io.readFileAlloc(allocator, file_path) catch |err| {
             try stderr.print("unable to open '{}': {}", file_path, err);
+            fmt_errors = true;
             continue;
         };
         defer allocator.free(source_code);
 
         var tree = std.zig.parse(allocator, source_code) catch |err| {
             try stderr.print("error parsing file '{}': {}\n", file_path, err);
+            fmt_errors = true;
             continue;
         };
         defer tree.deinit();
@@ -752,6 +755,7 @@ fn cmdFmt(allocator: *Allocator, args: []const []const u8) !void {
             try errmsg.printToFile(&stderr_file, msg, color);
         }
         if (tree.errors.len != 0) {
+            fmt_errors = true;
             continue;
         }
 
@@ -764,6 +768,10 @@ fn cmdFmt(allocator: *Allocator, args: []const []const u8) !void {
             try baf.finish();
         }
     }
+
+    if (fmt_errors) {
+        os.exit(1);
+    }
 }
 
 // cmd:targets /////////////////////////////////////////////////////////////////////////////////////

Original file line number	Diff line number	Diff line change
`@@ -728,18 +728,21 @@ fn cmdFmt(allocator: *Allocator, args: []const []const u8) !void {`
`728`	`728`	`}`
`729`	`729`	`};`
`730`	`730`
	`731`	`+ var fmt_errors = false;`
`731`	`732`	`for (flags.positionals.toSliceConst()) \|file_path\| {`
`732`	`733`	`var file = try os.File.openRead(allocator, file_path);`
`733`	`734`	`defer file.close();`
`734`	`735`
`735`	`736`	`const source_code = io.readFileAlloc(allocator, file_path) catch \|err\| {`
`736`	`737`	`try stderr.print("unable to open '{}': {}", file_path, err);`
	`738`	`+ fmt_errors = true;`
`737`	`739`	`continue;`
`738`	`740`	`};`
`739`	`741`	`defer allocator.free(source_code);`
`740`	`742`
`741`	`743`	`var tree = std.zig.parse(allocator, source_code) catch \|err\| {`
`742`	`744`	`try stderr.print("error parsing file '{}': {}\n", file_path, err);`
	`745`	`+ fmt_errors = true;`
`743`	`746`	`continue;`
`744`	`747`	`};`
`745`	`748`	`defer tree.deinit();`
`@@ -752,6 +755,7 @@ fn cmdFmt(allocator: *Allocator, args: []const []const u8) !void {`
`752`	`755`	`try errmsg.printToFile(&stderr_file, msg, color);`
`753`	`756`	`}`
`754`	`757`	`if (tree.errors.len != 0) {`
	`758`	`+ fmt_errors = true;`
`755`	`759`	`continue;`
`756`	`760`	`}`
`757`	`761`
`@@ -764,6 +768,10 @@ fn cmdFmt(allocator: *Allocator, args: []const []const u8) !void {`
`764`	`768`	`try baf.finish();`
`765`	`769`	`}`
`766`	`770`	`}`
	`771`	`+`
	`772`	`+ if (fmt_errors) {`
	`773`	`+ os.exit(1);`
	`774`	`+ }`
`767`	`775`	`}`
`768`	`776`
`769`	`777`	`// cmd:targets /////////////////////////////////////////////////////////////////////////////////////`