Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libarchive: pull in patch to support LibresSSL-2.7. #41395

Merged
merged 1 commit into from Jun 3, 2018
Merged

libarchive: pull in patch to support LibresSSL-2.7. #41395

merged 1 commit into from Jun 3, 2018

Conversation

qolii
Copy link
Contributor

@qolii qolii commented Jun 2, 2018

Motivation for this change

The current release of libarchive does not support libressl-2.7. This patch from upstream adds support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

Thanks for your PR!

Because of the rather large rebuild could you rebase this on staging?
We try to avoid mass-rebuilds on master.

@orivej orivej changed the base branch from master to staging June 3, 2018 17:46
@orivej orivej merged commit 20d83e2 into NixOS:staging Jun 3, 2018
@qolii qolii deleted the libarchive_libressl_patch branch June 3, 2018 21:38
@orivej
Copy link
Contributor

orivej commented Jun 4, 2018

Fixed patch hash in 957810e. @volth Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qolii @adisbladis @orivej @GrahamcOfBorg