gshogi: init at 0.5.1 #41840
Merged
gshogi: init at 0.5.1 #41840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build gshogi |
|
Success on x86_64-linux (full log) Attempted: gshogi Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: gshogi Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gshogi Partial log (click to expand)
|
xeji
reviewed
Jun 11, 2018
pkgs/games/gshogi/default.nix
Outdated
| buildPythonApplication rec { | ||
| pname = "gshogi"; | ||
| version = "0.5.1"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
This line is not necessary for python apps since name is derived automatically. Please delete.
| meta = with stdenv.lib; { | ||
| description = "A graphical implementation of the Shogi board game, also known as Japanese Chess"; | ||
| homepage = http://johncheetham.com/projects/gshogi/; | ||
| license = licenses.gpl3; |
There was a problem hiding this comment.
Doesn't build on darwin (the error looks like incompatible code), please restrict to linux by adding
platforms = platforms.linux; here.
There was a problem hiding this comment.
Thanks. Didn't have any darwin machines available, so I thought might as well try. Changed now.
| pygobject3 | ||
| pycairo | ||
| ]; | ||
|
|
There was a problem hiding this comment.
----------------------------------------------------------------------
Ran 0 tests in 0.000s
Since the package doesn't provide tests, disable them:
doCheck = false; # no tests available
|
@GrahamcOfBorg build gshogi |
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: gshogi Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: gshogi Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gshogi Partial log (click to expand)
|
orivej
added a commit
that referenced
this pull request
Jun 12, 2018
* master: (161 commits) pcsclite: clean up after #41790 tor: 0.3.3.6 -> 0.3.3.7 opae: init at 1.0.0 tinc: 1.0.33 -> 10.0.34 tinc_pre: 1.1pre15 -> 1.1pre16 sit: 0.3.2 -> 0.4.0 (#41863) platforms/raspberrypi: enable kernelAutoModules libupnp: 1.6.21 -> 1.8.3 (#41684) androidStudioPackages.{dev,canary}: 3.2.0.16 -> 3.2.0.17 tdesktop: 1.3.0 -> 1.3.7 gns3Packages.{server,gui}{Stable,Preview}: 2.1.6 -> 2.1.7 aws-sam-cli: init at 0.3.0 (#41877) nixos/nat: optional networking.nat.externalInterface (#41864) linux: 4.17 -> 4.17.1 linux: 4.16.14 -> 4.16.15 linux: 4.14.48 -> 4.14.49 nixos/unbound: add restart (#41885) maintainers/create-azure.sh: remove hydra.nixos.org as binary cache (#41883) gshogi: init at 0.5.1 (#41840) neovim: add missing libiconv ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)