nixos/tor: fix systemd service #41852
Conversation
…enings This reverts a part of 5bd12c6. Apparently there's no way to specify user for RuntimeDirectory in systemd service file (it's always root) but tor won't create control socket if the dir is owned by anybody except the tor user. These hardenings were adopted from the upstream service file, checked against systemd.service(5) and systemd.exec(5) manuals, and tested to actually work with all the options enabled. `PrivateDevices` implies `DevicePolicy=closed` according to systemd.exec(5), removed. `--RunAsDaemon 0` is the default value according to tor(5), removed.
|
I think we should instead run the systemd service as the |
|
possible?
Probably not, unless you are willing to patch systemd. AFAICS, according to systemd.service(5) and other mentioned manuals, systemd provides no options for specifying file modes for those directories and this patchset sets different modes for different purposes (it makes total sense to hide tor state and onion private keys from prying eyes).
It also has an advantages of being simple, of using standard tools only, and hence of being easily portable between init systems unlike those systemd-specific options (NixOS doesn't care about that latter point, but still).
|
|
If the separate service thing works that seems fine to me ... Depending on how tor does its privsep, it may even be preferrable to let it do its thing anyway. An alternative is to set |
|
Makes sense to me to just merge this & maybe iterate later. Thank you. |
Kindly contributed fix to what #39083 apparently broke when fixing what #37827 broke.
@dotlambda, can you verify it works with your config? Let's try really hard not to break anything this time.