Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish the \a escape sequence #6176

Closed
wants to merge 2 commits into from
Closed

Finish the \a escape sequence #6176

wants to merge 2 commits into from

Conversation

wooster0
Copy link
Contributor

This finishes the \a escape sequence.

@wooster0
Copy link
Contributor Author

Huh? It failed again? I thought CI is using 0.25.0 now.

@z64
Copy link
Contributor

z64 commented Jun 18, 2018

You didn't rebase onto a branch that includes the CI script fix. You have to update your local master branch first, then rebase this branch on top of it, then force push it.

@asterite
Copy link
Member

Anyone cares to read the build failure details? It says the formatter produces changes. Please format your PR changes with the formatter (crystal tool format).

@wooster0
Copy link
Contributor Author

Sorry I can't access the finishescapesequence branch anymore... I already tried a lot of things.
It says unknown repository on the top now. I deleted my fork and forked again so I have the CI script fix in it. But that was dumb I know.
CI fails just because of this one space at the end of the '\a'.ord.should eq(7) line in spec/std/char_spec.cr. :/

@straight-shoota
Copy link
Member

You'll have to create a new PR for your branch.

@wooster0 wooster0 closed this Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants