use defineProperty for property based descriptor depreciation
#16742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Jun 12, 2018
There was a problem hiding this comment.
Hmm, I think that @krisselden did this on purpose because we only need one of the paths in Ember.defineProperty...
|
@krisselden - Can you confirm? |
bekzod
force-pushed
the
use-define-property
branch
from
9535780
to
9f8c8ae
Compare
|
@rwjblue confirm. This is so the deprecation is cleanly removed with the deprecated feature when using a svelte build. |
|
cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.