trash-cli: enable darwin build #41847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +17,8 @@ python3Packages.buildPythonApplication rec { | |||
| (substituteAll { | |||
| src = ./nix-paths.patch; | |||
| df = "${coreutils}/bin/df"; | |||
| libc = "${stdenv.cc.libc.out}/lib/libc.so.6"; | |||
| libc = let ext = if stdenv.isDarwin then ".dylib" else ".so.6"; | |||
There was a problem hiding this comment.
I think you can replace this with: stdenv.hostPlatform.extensions.sharedLibrary. The .6 part should be optional.
There was a problem hiding this comment.
Thanks for suggestion. I replaced this line with
libc = "${stdenv.cc.libc}/lib/libc${stdenv.hostPlatform.extensions.sharedLibrary}";
and the build failed with
OSError: /nix/store/pr73kx0cdszbv9iw49g8dzi0nqxfjbx2-glibc-2.27/lib/libc.so: invalid ELF header
on Linux. .6 seems to be necessary.
There was a problem hiding this comment.
Very weird never mind then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)