Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 3ffb84daf34a
Choose a base ref
...
head repository: jruby/jruby
compare: 193d604e4f0d
Choose a head ref
  • 3 commits
  • 22 files changed
  • 1 contributor

Commits on Jun 11, 2018

  1. revisit FileResource interface and its impls 

    - review 'hacky' naming and declared throws - support unwrapping
- avoid some potential NPEs dealing with null args (e.g. runtime)
+ internal ResourceException is simply mapped to RaiseExceptions
  (and avoid trace since ResourceException sub-types are caught)
    @kares
    kares committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    b562dcc View commit details
    Browse the repository at this point in the history

  2. [refactor] avoid deprecated API usage

    @kares
    kares committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    9464336 View commit details
    Browse the repository at this point in the history

  3. [refactor] File expad-path internal (to do less) 

    work esp. char[] copy-ing; also assuming cwd isn't null
    @kares
    kares committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    193d604 View commit details
    Browse the repository at this point in the history