Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.typing-extensions: init at 3.6.5 #40983

Merged
merged 1 commit into from Jun 5, 2018
Merged

pythonPackages.typing-extensions: init at 3.6.5 #40983

merged 1 commit into from Jun 5, 2018

Conversation

pmiddend
Copy link
Contributor

Motivation for this change

This package is missing from nixpkgs (and is different than the existing typing).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pmiddend pmiddend requested a review from FRidh as a code owner May 23, 2018 11:28
FRidh
FRidh reviewed May 23, 2018
View reviewed changes
pkgs/development/python-modules/typing-extensions/default.nix Outdated
sha256 = "09xxykw8mk30r0g33r2gy5qlqw3sqj5vkp6h7nh0flp59hxqw2hw";
};

buildInputs = [ typing ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test dependency? build dependency, run-time dependency?

@pmiddend
Copy link
Contributor Author

@FRidh I fixed the issue (it was checkInputs).

teto
teto reviewed May 24, 2018
View reviewed changes
pkgs/development/python-modules/typing-extensions/default.nix Outdated
@@ -0,0 +1,31 @@
{ lib, buildPythonPackage, fetchPypi, pythonOlder, isPy3k, python, pytest, tox, typing }:
let
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither tox nor pytest seem used

@FRidh
Copy link
Member

FRidh commented May 24, 2018

@GrahamcOfBorg build python2.pkgs.typing-extensions python3.pkgs.typing-extensions

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.typing-extensions, python3.pkgs.typing-extensions

Partial log (click to expand)

patching script interpreter paths in /nix/store/gc8jwfpnrx91z9zbv4v6wz95g8lwrl9p-python3.6-typing_extensions-3.6.5
patching script interpreter paths in /nix/store/57wdm1dpxk5jkg13n5xcnyrxcm8rihlg-python2.7-typing_extensions-3.6.5
running install tests
...................................................
----------------------------------------------------------------------
Ran 51 tests in 0.111s

OK
/nix/store/57wdm1dpxk5jkg13n5xcnyrxcm8rihlg-python2.7-typing_extensions-3.6.5
/nix/store/gc8jwfpnrx91z9zbv4v6wz95g8lwrl9p-python3.6-typing_extensions-3.6.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.typing-extensions, python3.pkgs.typing-extensions

Partial log (click to expand)

Successfully installed typing-extensions-3.6.5
/build/typing_extensions-3.6.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pn1i703zzdcyszy4z69axllall5q76ys-python3.6-typing_extensions-3.6.5
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pn1i703zzdcyszy4z69axllall5q76ys-python3.6-typing_extensions-3.6.5/lib
patching script interpreter paths in /nix/store/pn1i703zzdcyszy4z69axllall5q76ys-python3.6-typing_extensions-3.6.5
checking for references to /build in /nix/store/pn1i703zzdcyszy4z69axllall5q76ys-python3.6-typing_extensions-3.6.5...
/nix/store/d0p5f19z64yyw0bd31an6avckzlg3wik-python2.7-typing_extensions-3.6.5
/nix/store/pn1i703zzdcyszy4z69axllall5q76ys-python3.6-typing_extensions-3.6.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.typing-extensions, python3.pkgs.typing-extensions

Partial log (click to expand)

patching script interpreter paths in /nix/store/hmzjjcva26fmzs7msd3as333mmm2qr05-python3.6-typing_extensions-3.6.5
checking for references to /build in /nix/store/hmzjjcva26fmzs7msd3as333mmm2qr05-python3.6-typing_extensions-3.6.5...
running install tests
...................................................
----------------------------------------------------------------------
Ran 51 tests in 0.296s

OK
/nix/store/mb71s0pzpvl6p1kxf6dgysin0hzyplms-python2.7-typing_extensions-3.6.5
/nix/store/hmzjjcva26fmzs7msd3as333mmm2qr05-python3.6-typing_extensions-3.6.5

@pmiddend
Copy link
Contributor Author

pmiddend commented Jun 3, 2018

Is it mergeable?

@FRidh
Copy link
Member

FRidh commented Jun 3, 2018

Could you amend the commit message to refer to the correct package set.

@pmiddend
Copy link
Contributor Author

pmiddend commented Jun 3, 2018

@FRidh I'm not sure what you mean. Should it be pythonPackages? The package is compatible with python 2.x and 3.x.

@PsyanticY
Copy link
Contributor

@pmiddend I think he means it should be pythonPackages.typing-extensions: init at 3.6.5 .

@pmiddend
Copy link
Contributor Author

pmiddend commented Jun 4, 2018

@Assassinkin Ah okay, I've fixed that now.

@dotlambda dotlambda changed the title pythonPkgs.typing-extensions: init at 3.6.5 pythonPackages.typing-extensions: init at 3.6.5 Jun 5, 2018
dotlambda
dotlambda reviewed Jun 5, 2018
View reviewed changes
pkgs/development/python-modules/typing-extensions/default.nix Outdated
description = "Backported and Experimental Type Hints for Python 3.5+";
homepage = https://github.com/python/typing;
license = licenses.psfl;
maintainers = with lib.maintainers; [ pmiddend ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no lib

dotlambda
dotlambda reviewed Jun 5, 2018
View reviewed changes
pkgs/development/python-modules/typing-extensions/default.nix Outdated
sha256 = "09xxykw8mk30r0g33r2gy5qlqw3sqj5vkp6h7nh0flp59hxqw2hw";
};

checkInputs = if isPy3k then [] else [ typing ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib.optional (!isPy3k) typing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think it should be pythonOlder "3.5" because typing is only part of the standard library since 3.5: https://docs.python.org/3/library/typing.html

@pmiddend
Copy link
Contributor Author

pmiddend commented Jun 5, 2018

@dotlambda Thanks for the feedback, fixed.

@dotlambda dotlambda merged commit 1868fa9 into NixOS:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@FRidh FRidh FRidh left review comments

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pmiddend @FRidh @GrahamcOfBorg @PsyanticY @teto @dotlambda