Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strace: fix libunwind detection by fixing use of lib.optional #40994

Merged
merged 1 commit into from
May 23, 2018
Merged

strace: fix libunwind detection by fixing use of lib.optional #40994

merged 1 commit into from
May 23, 2018
+1 −1

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 23, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 23, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: strace

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: strace

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22
shrinking /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22/bin/strace
gzipping man pages under /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22/bin
patching script interpreter paths in /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22
/nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22/bin/strace-graph: interpreter directive changed from "/usr/bin/perl" to "/nix/store/cxdmh98g0lvl1dyq304c1lq7f90dh01f-perl-5.24.3/bin/perl"
/nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22/bin/strace-log-merge: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22...
/nix/store/wgjn46wwj7b0rgvpgcgb1xs0jdw1vgy2-strace-4.22

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: strace

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22
shrinking /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22/bin/strace
gzipping man pages under /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22/bin
patching script interpreter paths in /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22
/nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22/bin/strace-log-merge: interpreter directive changed from "/bin/sh" to "/nix/store/l4w7xwjy2nmk31fl5kgyy7gg8z7l9n8z-bash-4.4-p19/bin/sh"
/nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22/bin/strace-graph: interpreter directive changed from "/usr/bin/perl" to "/nix/store/lind05r5ydb20phsj39zf7kyjkavwj02-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22...
/nix/store/8cikkrw7b3zs949jcdwp9fqcsl47nbv0-strace-4.22

@xeji xeji merged commit 4bf6889 into NixOS:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @xeji