Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.clustershell: init at 1.8 #40959

Merged
merged 1 commit into from Jun 23, 2018
Merged

pythonPackages.clustershell: init at 1.8 #40959

merged 1 commit into from Jun 23, 2018

Conversation

alexvorobiev
Copy link
Contributor

@alexvorobiev alexvorobiev commented May 23, 2018 •
edited

Motivation for this change

NixOS derivation for ClusterShell (http://clustershell.readthedocs.io/en/latest/intro.html)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@alexvorobiev alexvorobiev requested a review from FRidh as a code owner May 23, 2018 03:40
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.clustershell python3.pkgs.clustershell

@alexvorobiev Please squash the commits and change the commit message to match the contribution guidelines and Nixpkgs manual.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.clustershell, python3.pkgs.clustershell

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'lib/ClusterShell.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/8mvs1g20j9cnzv4klqndqv5ckr2kmc8n-python2.7-ClusterShell-1.8
/nix/store/bynm5fnmv4nsygjcf148747nxvvdbw07-python3.6-ClusterShell-1.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.clustershell, python3.pkgs.clustershell

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'lib/ClusterShell.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/rrhbsa3hfgbxrq68w3z1sg03ri3nfirx-python2.7-ClusterShell-1.8
/nix/store/611gwi3il7b4ghs7sn5f17lcympwa29l-python3.6-ClusterShell-1.8

@FRidh
Copy link
Member

FRidh commented May 23, 2018 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

@alexvorobiev
Copy link
Contributor Author

Thanks for the feedback!
@FRidh the package has about 900 unit tests and a significant number of them tries to open network connections (https://github.com/cea-hpc/clustershell/blob/master/README.md#test-suite). I will try to figure out which tests to disable.

@FRidh
Copy link
Member

FRidh commented May 27, 2018

@GrahamcOfBorg build python2.pkgs.clustershell python3.pkgs.clustershell

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.clustershell, python3.pkgs.clustershell

Partial log (click to expand)

  File "/build/ClusterShell-1.8/tests/WorkerExecTest.py", line 52, in test_timeout
    self.assertEqual(task_self().num_timeout(), 2)
AssertionError: 1 != 2

----------------------------------------------------------------------
Ran 485 tests in 86.904s

FAILED (failures=7)
builder for '/nix/store/5qv2siay0gmh9yb1walmab3q0b2nsx78-python3.6-ClusterShell-1.8.drv' failed with exit code 1
error: build of '/nix/store/5qv2siay0gmh9yb1walmab3q0b2nsx78-python3.6-ClusterShell-1.8.drv', '/nix/store/68r3cpqa13ipw9r5njdkq6140nw76yfh-python2.7-ClusterShell-1.8.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.clustershell, python3.pkgs.clustershell

Partial log (click to expand)

  File "/build/ClusterShell-1.8/tests/WorkerExecTest.py", line 52, in test_timeout
    self.assertEqual(task_self().num_timeout(), 2)
AssertionError: 1 != 2

----------------------------------------------------------------------
Ran 485 tests in 223.754s

FAILED (failures=8)
builder for '/nix/store/0ik7v2z2l2522nzji944zqkmiy5ypjpm-python2.7-ClusterShell-1.8.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/0ik7v2z2l2522nzji944zqkmiy5ypjpm-python2.7-ClusterShell-1.8.drv', '/nix/store/x5ngjfwdkzp50k27aczgy8d6i9xj7mrw-python3.6-ClusterShell-1.8.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python2.pkgs.clustershell, python3.pkgs.clustershell

Partial log (click to expand)

cannot build derivation '/nix/store/pd6ilarj1ibp4y8gwfhvd2lpgwjq3mmh-python3.6-setuptools-39.0.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/51bb77yp3c5g62phv05dzph3kzv9j9qi-python2.7-PyYAML-3.12.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/mj1nlcc8k7n1i3zh1g7vwb4rss0ib4pi-python2.7-coverage-4.5.1.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/w5qjmzm81rvy0c9z2p1j3r95ba93ls16-python3.6-PyYAML-3.12.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/vbx1vf1swmc8z64gd1iik6x3v0805bfj-python3.6-coverage-4.5.1.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/qbyxg9ph7np1nqlawdigds9mjd1wl22m-python2.7-nose-1.3.7.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/ql9b43xc7mwri9lsifn1722m92g03bvv-python3.6-nose-1.3.7.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/rjvz82dkzfk162bgadsqj59niw88ykqh-python2.7-ClusterShell-1.8.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/708l52d2djyxfr4rcliqwaj84y279mr3-python3.6-ClusterShell-1.8.drv': 12 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/708l52d2djyxfr4rcliqwaj84y279mr3-python3.6-ClusterShell-1.8.drv', '/nix/store/rjvz82dkzfk162bgadsqj59niw88ykqh-python2.7-ClusterShell-1.8.drv' failed

@alexvorobiev
Copy link
Contributor Author

alexvorobiev commented Jun 21, 2018 •
edited

@dotlambda @FRidh 600+ unit tests now run and all the commits are squashed.

@FRidh FRidh changed the title Added pythonPackages.clustershell pythonPackages.clustershell: init at 1.8 Jun 23, 2018
@FRidh
Copy link
Member

FRidh commented Jun 23, 2018

@GrahamcOfBorg build python2.pkgs.clustershell python3.pkgs.clustershell

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.clustershell, python3.pkgs.clustershell

Partial log (click to expand)

test ExecWorker with an error command on localhost ... ok
test ExecWorker reverse copying with wrong directory ... ok
test ExecWorker with a command using shell syntax ... ok

----------------------------------------------------------------------
Ran 645 tests in 154.420s

OK
/nix/store/apklh6z2xpybv0vk14qa1dza2g1fafnz-python2.7-ClusterShell-1.8
/nix/store/3byyplng785rb801zfd457rqdp2l4hsw-python3.6-ClusterShell-1.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.clustershell, python3.pkgs.clustershell

Partial log (click to expand)

test ExecWorker with an error command on localhost ... ok
test ExecWorker reverse copying with wrong directory ... ok
test ExecWorker with a command using shell syntax ... ok

----------------------------------------------------------------------
Ran 645 tests in 721.520s

OK
/nix/store/lqcvww37ygkszsmphzjcxg1mz2dgm8j6-python2.7-ClusterShell-1.8
/nix/store/bfci1aynswdd0yw3kyasbvnq4fqy0khj-python3.6-ClusterShell-1.8

@FRidh FRidh merged commit fc4ab42 into NixOS:master Jun 23, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python2.pkgs.clustershell, python3.pkgs.clustershell

Partial log (click to expand)

cannot build derivation '/nix/store/16svj6ssq7cg10npi6ygynd2z56misyy-boost-1.67_0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cfwchyklsyahrl8w7giadmgq01gla6kv-PlistCpp-11615d.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6rq3y0qggm0zrjim2aiwq9yzmj207319-xib2nib-730e177.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/g1y596caldpyx9csvnk5bckfv15yyq1n-nixpkgs.xctoolchain.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bl58g5fa42vblnkwfdmgihk004vjp759-xcbuild-wrapper-0.1.2-pre.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/snfpix8fbgj2vv5yhl8lp21dpmp247fq-shell_cmds-osx-10.11.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hdcq77jxa7knpxdfbiw5m81m14hpq9pc-hostname-1003.1-2008.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j8jmb6159xpqx7xsjs09i0lwk0lgn8zc-python2.7-ClusterShell-1.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qgwsg479hwk48rkki8sr0q700x16xryx-python3.6-ClusterShell-1.8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/j8jmb6159xpqx7xsjs09i0lwk0lgn8zc-python2.7-ClusterShell-1.8.drv', '/nix/store/qgwsg479hwk48rkki8sr0q700x16xryx-python3.6-ClusterShell-1.8.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexvorobiev @dotlambda @GrahamcOfBorg @FRidh @xeji