Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin stdenv: Persist darwin.binutils-unwrapped #40991

Merged
merged 1 commit into from
May 23, 2018
Merged

darwin stdenv: Persist darwin.binutils-unwrapped #40991

merged 1 commit into from
May 23, 2018
+1 −1

Conversation

Ericson2314
Copy link
Member

Motivation for this change

binutils-unwrapped was added in ef3db7d
and needs a corresponding persisted attr in the Darwin stdenv.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ericson2314
darwin stdenv: Persist darwin.binutils-unwrapped
64c90e5 
binutils-unwrapped was added in ef3db7d
and needs a corresponding `persisted` attr in the Darwin stdenv.
@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 6.topic: stdenv Standard environment labels May 23, 2018
@Ericson2314 Ericson2314 merged commit e3f35d1 into NixOS:master May 23, 2018
@Ericson2314 Ericson2314 deleted the stdenv-darwin-persist branch May 23, 2018 13:58
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg