fix: workaround premature metadata generation on page save 馃悰 #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the creator of a new page was not saved to metadata. That could happen if a plugin calls pageinfo() in the IO_WIKIPAGE_WRITE event AFTER handler. This creates a new .meta file for the page with the page's mtime as the creation timestamp. That caused the if clause changed in this commit to evaluate as false and thus the creator key was not saved. This commit now also treats the page as newly created if the created date in the metadata to the file's current mtime.
micgro42
added a commit
to cosmocode/dokuwiki-plugin-publish
that referenced
this pull request
May 23, 2018
Calling pageinfo() durint IO_WIKIPAGE_WRITE of newly created pages caused the page's metadata file to be written prematurely which in turn caused the creator to be omitted from the page's metadata. This reworks the create_mail_body action to no longer call pageinfo(). See also dokuwiki/dokuwiki#2401
micgro42
added a commit
to cosmocode/dokuwiki-plugin-publish
that referenced
this pull request
May 23, 2018
Calling pageinfo() durint IO_WIKIPAGE_WRITE of newly created pages caused the page's metadata file to be written prematurely which in turn caused the creator to be omitted from the page's metadata. This reworks the create_mail_body action to no longer call pageinfo(). See also dokuwiki/dokuwiki#2401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the creator of a new page was not saved to metadata.
That could happen if a plugin calls
pageinfo()in theIO_WIKIPAGE_WRITEevent's AFTER handler. This creates a new
.metafile for the page with thepage's mtime as the creation timestamp. That caused the if clause
changed in this commit to evaluate as false and thus the creator key was
not saved.
This commit now also treats the page as newly created if the created
date in the metadata is equal to the file's current mtime.