fplll: 5.2.0 -> 5.2.1, pythonPackages.fpylll: 0.3.0dev -> 0.4.0dev #40995

timokau · 2018-05-23T14:40:24Z

Motivation for this change

This fixes the fpylll tests on 32 bit machines (see fplll/fpylll#112).

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-05-23T14:52:16Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fplll

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-23T14:54:19Z

Success on x86_64-linux (full log)

Attempted: fplll

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1
shrinking /nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1/lib/libfplll.so.5.0.0
shrinking /nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1/bin/fplll
shrinking /nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1/bin/latticegen
shrinking /nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1/bin/latsieve
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1/lib  /nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1/bin
patching script interpreter paths in /nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1
checking for references to /build in /nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1...
/nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1

GrahamcOfBorg · 2018-05-23T15:05:43Z

Success on aarch64-linux (full log)

Attempted: fplll

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1
shrinking /nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1/bin/latsieve
shrinking /nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1/bin/latticegen
shrinking /nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1/bin/fplll
shrinking /nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1/lib/libfplll.so.5.0.0
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1/lib  /nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1/bin
patching script interpreter paths in /nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1
checking for references to /build in /nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1...
/nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1

timokau · 2018-05-23T15:17:53Z

I needed to add a patch to fix the README encoding for python3 (fplll/fpylll#121).

@GrahamcOfBorg build python2Packages.fpylll python3Packages.fpylll

GrahamcOfBorg · 2018-05-23T15:25:01Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python2Packages.fpylll, python3Packages.fpylll

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-23T15:26:02Z

Success on x86_64-linux (full log)

Attempted: python2Packages.fpylll, python3Packages.fpylll

Partial log (click to expand)

tests/test_precision.py .                                                [ 75%]
tests/test_pruner.py .                                                   [ 79%]
tests/test_random.py .                                                   [ 83%]
tests/test_simple_bkz.py ..                                              [ 91%]
tests/test_strategies.py .                                               [ 95%]
tests/test_util.py .                                                     [100%]

========================== 24 passed in 24.02 seconds ==========================
/nix/store/js2piqgvdna5jyn487l16vls55idny8l-python2.7-fpylll-0.4.0dev
/nix/store/dddj023c6mv44pafwfy10b8sxxcwzlfy-python3.6-fpylll-0.4.0dev

GrahamcOfBorg · 2018-05-23T16:18:29Z

Failure on aarch64-linux (full log)

Attempted: python2Packages.fpylll, python3Packages.fpylll

Partial log (click to expand)

/nix/store/6p0715xklf0qr64ia3jqaav47j31ds2j-python2.7-numpy-1.14.2/lib/python2.7/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^~~~~~~
building of '/nix/store/xpg1zk3gwmlapnsvlmvw3p3zizs7c3ky-python2.7-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/i9ixr29088pfvf859bg98b21p173dig5-python2.7-cysignals-1.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4h4hpd4n82x7m7jjgamgyljvh8rdjz5m-python2.7-fpylll-0.4.0dev.drv': 2 dependencies couldn't be built
building of '/nix/store/xpci0kq0rbsvj7ag9an298cy2z34skhy-python3.6-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/qp0q7gwpwbqmblldjki2y8xh2qd4f48n-python3.6-cysignals-1.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7vb33x30xj0jkkqpbv3gac4hfcjfqfky-python3.6-fpylll-0.4.0dev.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/4h4hpd4n82x7m7jjgamgyljvh8rdjz5m-python2.7-fpylll-0.4.0dev.drv', '/nix/store/7vb33x30xj0jkkqpbv3gac4hfcjfqfky-python3.6-fpylll-0.4.0dev.drv' failed

timokau · 2018-05-23T16:27:12Z

"building of '/nix/store/xpg1zk3gwmlapnsvlmvw3p3zizs7c3ky-python2.7-Cython-0.28.1.drv' timed out after 3600 seconds"

Failure seems unrelated, I think this is ready for merge.

FRidh · 2018-05-23T16:38:20Z

pkgs/development/python-modules/fpylll/default.nix

@@ -46,6 +46,11 @@ buildPythonPackage rec {
    py.test
  '';

+  patches = [
+    # https://github.com/fplll/fpylll/issues/121
+    ./readme-encoding.patch


Upstream patched it
fplll/fpylll@8ce149b
They're fast :)

Yeah apparently the author is thinking about cutting a new release that includes that fix, so maybe its worth waiting for that (https://trac.sagemath.org/ticket/25404#comment:8).

I've updated to release 0.4.1 which includes the fix. I had to change from fetchPyPi to fetchFromGitHub since its not on PyPi yet, is that a problem? I think fetching straight from the source is better anyways if pypi doesn't have any other advantages.

timokau · 2018-05-24T13:17:55Z

@GrahamcOfBorg build python2Packages.fpylll python3Packages.fpylll

GrahamcOfBorg · 2018-05-24T13:18:19Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python2Packages.fpylll, python3Packages.fpylll

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-24T13:23:55Z

Success on x86_64-linux (full log)

Attempted: python2Packages.fpylll, python3Packages.fpylll

Partial log (click to expand)

tests/test_pruner.py::test_pruner PASSED                                 [ 79%]
tests/test_random.py::test_randomize PASSED                              [ 83%]
tests/test_simple_bkz.py::test_simple_bkz_init PASSED                    [ 87%]
tests/test_simple_bkz.py::test_simple_bkz_reduction PASSED               [ 91%]
tests/test_strategies.py::test_linear_pruning PASSED                     [ 95%]
tests/test_util.py::test_gh PASSED                                       [100%]

========================== 24 passed in 27.27 seconds ==========================
/nix/store/qgi5lb3f2j150fmkfv9qvxq2gwwfm92x-python2.7-fpylll-0.4.1dev
/nix/store/v4zjl5nszflfm05nd3ng4d4j54z0cprv-python3.6-fpylll-0.4.1dev

GrahamcOfBorg · 2018-05-24T13:28:59Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fplll

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-24T13:28:59Z

Success on x86_64-linux (full log)

Attempted: fplll

Partial log (click to expand)

/nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1

GrahamcOfBorg · 2018-05-24T13:32:41Z

Success on x86_64-linux (full log)

Attempted: fplll

Partial log (click to expand)

/nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1

GrahamcOfBorg · 2018-05-24T13:32:41Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fplll

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-24T13:32:59Z

Success on aarch64-linux (full log)

Attempted: fplll

Partial log (click to expand)

/nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1

GrahamcOfBorg · 2018-05-24T14:18:32Z

Failure on aarch64-linux (full log)

Attempted: python2Packages.fpylll, python3Packages.fpylll

Partial log (click to expand)

  ^~~~~~~
acquired default
acquired Global_A
building of '/nix/store/xpg1zk3gwmlapnsvlmvw3p3zizs7c3ky-python2.7-Cython-0.28.1.drv' timed out after 3600 seconds
building of '/nix/store/xpci0kq0rbsvj7ag9an298cy2z34skhy-python3.6-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/i9ixr29088pfvf859bg98b21p173dig5-python2.7-cysignals-1.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qp0q7gwpwbqmblldjki2y8xh2qd4f48n-python3.6-cysignals-1.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j0n234qqlznmv956aa5xb7glw5i0f58v-python2.7-fpylll-0.4.1dev.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/q4jb79lslmffa1438jk3h9g1lv0g16y0-python3.6-fpylll-0.4.1dev.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/j0n234qqlznmv956aa5xb7glw5i0f58v-python2.7-fpylll-0.4.1dev.drv', '/nix/store/q4jb79lslmffa1438jk3h9g1lv0g16y0-python3.6-fpylll-0.4.1dev.drv' failed

timokau · 2018-05-24T14:22:17Z

Failure is still unrelated.

dotlambda

Please split the commit into two seperate ones and add a pythonPackages. prefix to the appropriate one.

timokau · 2018-05-24T14:33:35Z

Its one commit for a reason since the two updates depend on each other. I've added the prefix.

dotlambda · 2018-05-24T14:34:45Z

@GrahamcOfBorg build fplll

GrahamcOfBorg · 2018-05-24T14:34:55Z

Success on x86_64-linux (full log)

Attempted: fplll

Partial log (click to expand)

/nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1

dotlambda · 2018-05-24T14:36:25Z

Thanks!

GrahamcOfBorg · 2018-05-24T14:37:26Z

Success on aarch64-linux (full log)

Attempted: fplll

Partial log (click to expand)

/nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1

GrahamcOfBorg · 2018-05-24T14:45:54Z

Success on x86_64-linux (full log)

Attempted: fplll

Partial log (click to expand)

/nix/store/6dax7pf10na7mr4syy8v0dbwsaiixzcy-fplll-5.2.1

GrahamcOfBorg · 2018-05-24T14:45:58Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fplll

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-24T14:47:22Z

Success on aarch64-linux (full log)

Attempted: fplll

Partial log (click to expand)

/nix/store/ss672gnmaa8w0zzqjhjbk1qdijhd0bkv-fplll-5.2.1

timokau requested a review from FRidh as a code owner May 23, 2018 14:40

GrahamcOfBorg added the 6.topic: python label May 23, 2018

timokau changed the title ~~fplll: 5.2.0 -> 5.2.1, fpylll: 0.3.0dev -> 0.4.0dev~~ [WIP] fplll: 5.2.0 -> 5.2.1, fpylll: 0.3.0dev -> 0.4.0dev May 23, 2018

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 23, 2018

timokau force-pushed the fplll-update branch from 8a96717 to 8e19a20 Compare May 23, 2018 15:17

timokau changed the title ~~[WIP] fplll: 5.2.0 -> 5.2.1, fpylll: 0.3.0dev -> 0.4.0dev~~ fplll: 5.2.0 -> 5.2.1, fpylll: 0.3.0dev -> 0.4.0dev May 23, 2018

FRidh reviewed May 23, 2018

View reviewed changes

timokau force-pushed the fplll-update branch from 8e19a20 to 663188e Compare May 24, 2018 13:15

timokau force-pushed the fplll-update branch from 663188e to 07aeabc Compare May 24, 2018 13:21

dotlambda requested changes May 24, 2018

View reviewed changes

fplll: 5.2.0 -> 5.2.1, pythonPackages.fpylll: 0.3.0dev -> 0.4.0dev

fe40994

timokau force-pushed the fplll-update branch from 07aeabc to fe40994 Compare May 24, 2018 14:33

timokau changed the title ~~fplll: 5.2.0 -> 5.2.1, fpylll: 0.3.0dev -> 0.4.0dev~~ fplll: 5.2.0 -> 5.2.1, pythonPackages.fpylll: 0.3.0dev -> 0.4.0dev May 24, 2018

dotlambda merged commit c8987a7 into NixOS:master May 24, 2018

timokau deleted the fplll-update branch May 24, 2018 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fplll: 5.2.0 -> 5.2.1, pythonPackages.fpylll: 0.3.0dev -> 0.4.0dev #40995

fplll: 5.2.0 -> 5.2.1, pythonPackages.fpylll: 0.3.0dev -> 0.4.0dev #40995

timokau commented May 23, 2018 •

edited

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

timokau commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

timokau commented May 23, 2018

FRidh May 23, 2018

timokau May 23, 2018

timokau May 24, 2018

timokau commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

timokau commented May 24, 2018

dotlambda left a comment •

edited

timokau commented May 24, 2018

dotlambda commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

dotlambda commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

fplll: 5.2.0 -> 5.2.1, pythonPackages.fpylll: 0.3.0dev -> 0.4.0dev #40995

fplll: 5.2.0 -> 5.2.1, pythonPackages.fpylll: 0.3.0dev -> 0.4.0dev #40995

Conversation

timokau commented May 23, 2018 • edited

Motivation for this change

Things done

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

timokau commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

GrahamcOfBorg commented May 23, 2018

timokau commented May 23, 2018

FRidh May 23, 2018

Choose a reason for hiding this comment

timokau May 23, 2018

Choose a reason for hiding this comment

timokau May 24, 2018

Choose a reason for hiding this comment

timokau commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

timokau commented May 24, 2018

dotlambda left a comment • edited

Choose a reason for hiding this comment

timokau commented May 24, 2018

dotlambda commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

dotlambda commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

timokau commented May 23, 2018 •

edited

dotlambda left a comment •

edited