Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gmailieer: 0.6 -> 0.8 #40997

Closed
wants to merge 1 commit into from
Closed

gmailieer: 0.6 -> 0.8 #40997

wants to merge 1 commit into from

Conversation

ayyess
Copy link
Contributor

@ayyess ayyess commented May 23, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 24, 2018

@GrahamcOfBorg build gmailieer

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: gmailieer

Partial log (click to expand)


----------------------------------------------------------------------
Ran 54 tests in 6.258s

FAILED (failures=1, skipped=7)
Test failed: <unittest.runner.TextTestResult run=54 errors=0 failures=1>
error: Test failed: <unittest.runner.TextTestResult run=54 errors=0 failures=1>
builder for '/nix/store/r4b4ay0d014n85i88890yax4l59ka6sh-python3.6-tqdm-4.21.0.drv' failed with exit code 1
cannot build derivation '/nix/store/c31v0nb1q74in34d3vxf3s2v8fqxzxk1-gmailieer.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/c31v0nb1q74in34d3vxf3s2v8fqxzxk1-gmailieer.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gmailieer

Partial log (click to expand)

writing top-level names to gmailieer.egg-info/top_level.txt
reading manifest file 'gmailieer.egg-info/SOURCES.txt'
writing manifest file 'gmailieer.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/qhx6l3324k3254aq4mz4id0xwy2d5pdx-gmailieer

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gmailieer

Partial log (click to expand)

writing top-level names to gmailieer.egg-info/top_level.txt
reading manifest file 'gmailieer.egg-info/SOURCES.txt'
writing manifest file 'gmailieer.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/jmhssa1fjkywbxb8f81s0b6z6h49dw08-gmailieer

xeji
xeji reviewed May 24, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to fix the Darwin build (it worked with a previous version) or restrict the package to platforms.linux.

pkgs/applications/networking/gmailieer/default.nix
@@ -2,13 +2,13 @@

python3Packages.buildPythonApplication rec {
name = "gmailieer";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please append the version to name here.

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

closing in favor of #42506

@xeji xeji closed this Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ayyess @xeji @GrahamcOfBorg