yarn2nix: successfully build packages with "@" and "/" in their name #41001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume this is better handled by nix-community/yarn2nix@44e16c6? |
nicknovitski
force-pushed
the
yarn2nix-names
branch
from
8f46187
to
2eec6a9
Compare
|
I adapted that change with what I believe to be a portable regex. |
nicknovitski
force-pushed
the
yarn2nix-names
branch
from
2eec6a9
to
7ac07dd
Compare
|
okay, this is not maintainable. We now have PRs submitted against nixpkgs and yarn2nix for the same code and it's starting to diverge. All PRs should be submitted to upstream. Updates to nixpkgs should only happen in the form: updated yarn2nix from |
|
Good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
My workplace releases "scoped" node packages, whose names can be things like
@scope/foo. It's possible to override the name of the package's derivation, but not that of the internal "modules" derivation the function creates, which will get an invalid name like@scope/foo-modules-0.0.1.I coped node2nix's pattern of replacing the characters with
_at_and_slash_.Things done
build-use-sandboxinnix.confon non-NixOS)- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)nix-shell -p nox --run "nox-review wip"./result/bin/)