buildRustPackage: preserve output from cargo-vendor #41519
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Dependencies specified as git repos are not working due to missing output in .cargo/config. This patch saves the output in fetchcargo and includes parts of it in the one regenerated in buildRustPackage. Note that the temporary cargo-config file must be removed prior to executing cargo update.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)I've setup a repository to demonstrate the working configuration: https://github.com/jbboehr/nix-fetch-cargo-update
I believe this implementation is a bit brittle. A "perfect" implementation would probably use a toml parser to remove or replace the relevant sections in
.cargo/config
.I tried running
nix-shell -p nox --run "nox-review wip"
but it crashed, maybe it affects too many packages?Fixes #41518