Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flent: fix fetchFromGitHub version #41520

Merged
merged 1 commit into from Jun 6, 2018
Merged

flent: fix fetchFromGitHub version #41520

merged 1 commit into from Jun 6, 2018

Conversation

teto
Copy link
Member

@teto teto commented Jun 6, 2018 •
edited

Lacked a "v" in revision.

Motivation for this change

before the change:

trying https://github.com/tohojo/flent/archive/1.2.2.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   119    0   119    0     0    171      0 --:--:-- --:--:-- --:--:--   171
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto
flent: fix fetchFromGitHub version
e14fa60 
Lacked a "v" in revision.
@grahamc
Copy link
Member

grahamc commented Jun 6, 2018

@GrahamcOfBorg build flent

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: flent

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: flent

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flent

Partial log (click to expand)

test_create_timeseries (unittests.test_plotters.TestPlotters) ... ok
test_create_timeseries_combine (unittests.test_plotters.TestPlotters) ... ok
test_load_tests (unittests.test_tests.TestTests) ... ok

----------------------------------------------------------------------
Ran 26 tests in 5.532s

OK
postPatchMkspecs
/nix/store/zjvbiz5di6bfxyqnki2symykia6l0634-flent-1.2.2

@grahamc grahamc merged commit 2e20d6f into NixOS:master Jun 6, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: flent

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flent

Partial log (click to expand)

test_create_timeseries (unittests.test_plotters.TestPlotters) ... ok
test_create_timeseries_combine (unittests.test_plotters.TestPlotters) ... ok
test_load_tests (unittests.test_tests.TestTests) ... ok

----------------------------------------------------------------------
Ran 26 tests in 3.398s

OK
postPatchMkspecs
/nix/store/zjvbiz5di6bfxyqnki2symykia6l0634-flent-1.2.2

@teto teto deleted the flent_fix branch June 6, 2018 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @grahamc @GrahamcOfBorg