Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm 6: Fix libcxxabi impurity and darwin sanitizers #42056

Merged
merged 1 commit into from Jun 14, 2018
Merged

llvm 6: Fix libcxxabi impurity and darwin sanitizers #42056

merged 1 commit into from Jun 14, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Pulled out of #42048

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Jun 14, 2018
@Ericson2314 Ericson2314 merged commit b2cc99e into NixOS:master Jun 14, 2018
@Ericson2314 Ericson2314 deleted the llvm-6-darwin-sanitize branch June 14, 2018 23:39
@matthewbauer
Copy link
Member

I don't think this fixed them:

https://hydra.nixos.org/build/75432711

@Ericson2314
Copy link
Member Author

Ericson2314 commented Jun 18, 2018 •
edited

Oh good catch I only fixed clang. Didn't attempt GCC.

@Ericson2314
Copy link
Member Author

Fixed with #42175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @matthewbauer @GrahamcOfBorg