add cross compilation regression test #1112

bnoordhuis · 2018-06-14T21:29:41Z

Verify that it's possible to build for the host architecture
and a different target architecture from a single build.zig.

The test doubles as a basic WebAssembly smoke test.

Verify that it's possible to build for the host architecture and a different target architecture from a single build.zig. The test doubles as a basic WebAssembly smoke test.

andrewrk · 2018-06-14T22:36:34Z

looks like llvm 6 from homebrew gave this error:
unable to create target based on: wasm32-unknown-unknown-wasm

I'm not sure why the linux travis ci versions worked, unless the llvm apt repos have the experimental targets enabled.

the windows one worked because it downloads my build of llvm which purposefully has web assembly enabled.

andrewrk · 2018-06-14T22:49:24Z

One option we have is to add a flag to the build to disable this test, and then only set this flag on travis for macos. Then we can remove the flag once homebrew gets an llvm version which has webassembly target enabled.

bnoordhuis · 2018-06-14T23:44:43Z

Sounds good. I'll look into that tomorrow.

andrewrk · 2018-06-15T17:43:12Z

Related: https://reviews.llvm.org/D43211

andrewrk · 2018-06-16T23:22:28Z

Oh, by the way, the test suite already tests building these targets:

zig/test/tests.zig

Lines 30 to 46 in c529b81

    
           const test_targets = []TestTarget{ 
        
               TestTarget{ 
        
                   .os = builtin.Os.linux, 
        
                   .arch = builtin.Arch.x86_64, 
        
                   .environ = builtin.Environ.gnu, 
        
               }, 
        
               TestTarget{ 
        
                   .os = builtin.Os.macosx, 
        
                   .arch = builtin.Arch.x86_64, 
        
                   .environ = builtin.Environ.unknown, 
        
               }, 
        
               TestTarget{ 
        
                   .os = builtin.Os.windows, 
        
                   .arch = builtin.Arch.x86_64, 
        
                   .environ = builtin.Environ.msvc, 
        
               }, 
        
           };

for all the build modes, on every platform. That's why you see printed a few times, when running the main test suite:

Created ./zig-cache/test but skipping execution because it is non-native.
Created ./zig-cache/test but skipping execution because it is non-native.
Created ./zig-cache/test but skipping execution because it is non-native.
Created ./zig-cache/test but skipping execution because it is non-native.
Created ./zig-cache/test.exe but skipping execution because it is non-native.
Created ./zig-cache/test.exe but skipping execution because it is non-native.
Created ./zig-cache/test.exe but skipping execution because it is non-native.
Created ./zig-cache/test.exe but skipping execution because it is non-native.

andrewrk · 2018-06-16T23:24:47Z

test/standalone/cross_compile/test.zig

+    var direct = std.heap.DirectAllocator.init();
+    defer direct.deinit();
+
+    const bytes = try std.io.readFileAlloc(&direct.allocator, "zig-cache/liblib.a");


Here's an example of how to do this without depending on zig-cache (which is supposed to be a black box):

zig/test/standalone/load_dynamic_library/main.zig

Lines 4 to 9 in c529b81

const args = try std.os.argsAlloc(std.debug.global_allocator);

defer std.os.argsFree(std.debug.global_allocator, args);

const dynlib_name = args[1];

var lib = try std.DynLib.open(std.debug.global_allocator, dynlib_name);

zig/test/standalone/load_dynamic_library/build.zig

Lines 12 to 15 in c529b81

const run = b.addCommand(".", b.env_map, [][]const u8{

main.getOutputPath(),

lib.getOutputPath(),

});

andrewrk · 2018-06-18T16:30:04Z

Cross compilation is pretty heavily tested in the main test suite. What this PR brings to the table is testing web assembly. Given that LLVM still has web assembly in the experimental targets list, I think it's not time to add web assembly to the test matrix yet. Let's revisit this when LLVM 7 comes out in September.

Feel free to push back on this, if you get CI reporting all green.

josephg · 2018-09-21T06:47:24Z

poke LLVM 7 is out, though removing WASM from the experimental targets list didn't quite make the cut. Also the wasm build is broken for exported symbols - see issue #1570.

add cross compilation regression test

deebee3

Verify that it's possible to build for the host architecture and a different target architecture from a single build.zig. The test doubles as a basic WebAssembly smoke test.

bnoordhuis mentioned this pull request Jun 15, 2018

llvm: enable wasm target Homebrew/homebrew-core#29068

Closed

4 tasks

andrewrk reviewed Jun 16, 2018

View reviewed changes

andrewrk closed this Jun 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add cross compilation regression test #1112

add cross compilation regression test #1112

bnoordhuis commented Jun 14, 2018

andrewrk commented Jun 14, 2018

andrewrk commented Jun 14, 2018

bnoordhuis commented Jun 14, 2018

andrewrk commented Jun 15, 2018

andrewrk commented Jun 16, 2018

andrewrk Jun 16, 2018

andrewrk commented Jun 18, 2018

josephg commented Sep 21, 2018

	const args = try std.os.argsAlloc(std.debug.global_allocator);
	defer std.os.argsFree(std.debug.global_allocator, args);

	const dynlib_name = args[1];

	var lib = try std.DynLib.open(std.debug.global_allocator, dynlib_name);

	const run = b.addCommand(".", b.env_map, [][]const u8{
	main.getOutputPath(),
	lib.getOutputPath(),
	});

add cross compilation regression test #1112

add cross compilation regression test #1112

Conversation

bnoordhuis commented Jun 14, 2018

andrewrk commented Jun 14, 2018

andrewrk commented Jun 14, 2018

bnoordhuis commented Jun 14, 2018

andrewrk commented Jun 15, 2018

andrewrk commented Jun 16, 2018

andrewrk Jun 16, 2018

Choose a reason for hiding this comment

andrewrk commented Jun 18, 2018

josephg commented Sep 21, 2018