Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: 2.20.2 -> 2.20.3 #42031

Merged
merged 1 commit into from Jun 14, 2018
Merged

webkitgtk: 2.20.2 -> 2.20.3 #42031

merged 1 commit into from Jun 14, 2018

Conversation

andir
Copy link
Member

@andir andir commented Jun 14, 2018

This addresses several issues with webkitgtk 2.20.2:

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
webkitgtk: 2.20.2 -> 2.20.3
5807246 
This addresses several issues with webkitgtk 2.20.2:

- CVE-2018-4190, information leak (credentials)
- CVE-2018-4199, arbitrary code execution
- CVE-2018-4218, arbitrary code execution
- CVE-2018-4222, arbitrary code execution
- CVE-2018-4232, cookies might be overriden
- CVE-2018-4233, arbitrary code execution
- CVE-2018-11646, application crash
- CVE-2018-12293, heap buffer overflow
@andir
Copy link
Member Author

andir commented Jun 14, 2018

@GrahamcOfBorg build webkitgtk

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: webkitgtk

Partial log (click to expand)

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:13 (project)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-webkitgtk-2.20.3.drv-0/webkitgtk-2.20.3/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-webkitgtk-2.20.3.drv-0/webkitgtk-2.20.3/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/490j3zv9mzc81mb5znwhyyhcl8216qi5-webkitgtk-2.20.3.drv' failed with exit code 1
error: build of '/nix/store/490j3zv9mzc81mb5znwhyyhcl8216qi5-webkitgtk-2.20.3.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: webkitgtk

Partial log (click to expand)

[1314/2152] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource405.cpp.o
[1315/2152] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource428.cpp.o
[1316/2152] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource403.cpp.o
[1317/2152] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource441.cpp.o
[1318/2152] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource432.cpp.o
[1319/2152] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource430.cpp.o
[1320/2152] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource438.cpp.o
[1321/2152] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource427.cpp.o
building of '/nix/store/z4b5wk4mkyibgmd3nzwn9b1fyddsb4zc-webkitgtk-2.20.3.drv' timed out after 3600 seconds
error: build of '/nix/store/z4b5wk4mkyibgmd3nzwn9b1fyddsb4zc-webkitgtk-2.20.3.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: webkitgtk

Partial log (click to expand)

[1426/2152] Building CXX object Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/MockPageOverlay.cpp.o
[1427/2152] Building CXX object Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/__/__/DerivedSources/WebCore/JSInternals.cpp.o
[1428/2152] Building CXX object Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/MockPageOverlayClient.cpp.o
[1429/2152] Building CXX object Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/__/__/DerivedSources/WebCore/JSTypeConversions.cpp.o
[1430/2152] Building CXX object Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/__/__/DerivedSources/WebCore/JSInternalSettingsGenerated.cpp.o
[1431/2152] Building CXX object Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/__/__/DerivedSources/WebCore/JSMockContentFilterSettings.cpp.o
[1432/2152] Building CXX object Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/testing/Internals.cpp.o
[1433/2152] Building CXX object Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/__/__/DerivedSources/WebCore/JSServiceWorkerInternals.cpp.o
building of '/nix/store/8halljkq32pghl0wnxrzvwh326xp54jg-webkitgtk-2.20.3.drv' timed out after 1800 seconds
error: build of '/nix/store/8halljkq32pghl0wnxrzvwh326xp54jg-webkitgtk-2.20.3.drv' failed

@andir andir merged commit a45d9b3 into NixOS:master Jun 14, 2018
@andir andir deleted the webkitgtk branch June 14, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @GrahamcOfBorg