Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: f1768778d9c2
Choose a base ref
...
head repository: jruby/jruby
compare: a60b38d4d900
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Jun 14, 2018

  1. Fixes #5162. Thread::Backtrace::Location#base_label for blocks differ… 

    …s from MRI.

This fix is not quite what I would have liked but I think the other issue we
will need to consider at some point is that this data is not m17n safe.  So
when we decide to fix that we will need to mangle differently and probably will
be able to clean up this a bit.
    @enebo
    enebo committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    9bfd29f View commit details
    Browse the repository at this point in the history

  2. Fixes #5163. When Thread::Backtrace::Location#base_label and #label a… 

    …re #== on MRI they are also #equal?

Our desire for laziness was the cause of this issue.  In the future we will
migrate to using symbol for methodNames to fully support M17n and this fix
ickiness will be able to be deleted.  Largely we use basename for all cases
except blocks.  In either case we save off the string we make so the equality
property is preserved.

With symbols the strings we have will always end up as the same string and
equality will also be true.  The amount of API changes is a bit too much to
do the m17n work now.
    @enebo
    enebo committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    d23a619 View commit details
    Browse the repository at this point in the history

  3. Whoops reversed logic.

    @enebo
    enebo committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    a60b38d View commit details
    Browse the repository at this point in the history