Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass: 1.7.1 -> 1.7.2 #42049

Merged
merged 1 commit into from Jun 15, 2018
Merged

pass: 1.7.1 -> 1.7.2 #42049

merged 1 commit into from Jun 15, 2018

Conversation

ciil
Copy link
Member

@ciil ciil commented Jun 14, 2018

Motivation for this change

Pass 1.7.2 has a number of important changes and bug fixes, including a fix
for CVE-2018-12356.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras
Copy link
Member

@GrahamcOfBorg build pass

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pass

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vby7aqc8ryaigx79wgaw5f078gb6ddwy-password-store-1.7.2
gzipping man pages under /nix/store/vby7aqc8ryaigx79wgaw5f078gb6ddwy-password-store-1.7.2/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vby7aqc8ryaigx79wgaw5f078gb6ddwy-password-store-1.7.2/lib  /nix/store/vby7aqc8ryaigx79wgaw5f078gb6ddwy-password-store-1.7.2/bin
patching script interpreter paths in /nix/store/vby7aqc8ryaigx79wgaw5f078gb6ddwy-password-store-1.7.2
/nix/store/vby7aqc8ryaigx79wgaw5f078gb6ddwy-password-store-1.7.2/bin/pass: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
/nix/store/vby7aqc8ryaigx79wgaw5f078gb6ddwy-password-store-1.7.2/bin/passmenu: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/vby7aqc8ryaigx79wgaw5f078gb6ddwy-password-store-1.7.2...
/nix/store/vby7aqc8ryaigx79wgaw5f078gb6ddwy-password-store-1.7.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pass

Partial log (click to expand)

install: creating directory '/nix/store/ww3h6irsi3840p1y4isd4zbqk2d7hqy7-password-store-1.7.2/lib/password-store/extensions'
install: creating directory '/nix/store/ww3h6irsi3840p1y4isd4zbqk2d7hqy7-password-store-1.7.2/bin/'
'src/.pass' -> '/nix/store/ww3h6irsi3840p1y4isd4zbqk2d7hqy7-password-store-1.7.2/bin/pass'
post-installation fixup
gzipping man pages under /nix/store/ww3h6irsi3840p1y4isd4zbqk2d7hqy7-password-store-1.7.2/share/man/
strip is /nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ww3h6irsi3840p1y4isd4zbqk2d7hqy7-password-store-1.7.2/lib  /nix/store/ww3h6irsi3840p1y4isd4zbqk2d7hqy7-password-store-1.7.2/bin
patching script interpreter paths in /nix/store/ww3h6irsi3840p1y4isd4zbqk2d7hqy7-password-store-1.7.2
/nix/store/ww3h6irsi3840p1y4isd4zbqk2d7hqy7-password-store-1.7.2/bin/pass: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash"
/nix/store/ww3h6irsi3840p1y4isd4zbqk2d7hqy7-password-store-1.7.2

@lukateras lukateras merged commit bf42591 into NixOS:master Jun 15, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pass

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7lf3asc6cg5j6nzy016dyinalmgbhskx-password-store-1.7.2
gzipping man pages under /nix/store/7lf3asc6cg5j6nzy016dyinalmgbhskx-password-store-1.7.2/share/man/
strip is /nix/store/3c42aixy417vmgs0h5yl5806zx81qz8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7lf3asc6cg5j6nzy016dyinalmgbhskx-password-store-1.7.2/lib  /nix/store/7lf3asc6cg5j6nzy016dyinalmgbhskx-password-store-1.7.2/bin
patching script interpreter paths in /nix/store/7lf3asc6cg5j6nzy016dyinalmgbhskx-password-store-1.7.2
/nix/store/7lf3asc6cg5j6nzy016dyinalmgbhskx-password-store-1.7.2/bin/passmenu: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/bkjfiwh7v0gbxfrynvm9xzj2h0xid604-bash-4.4-p19/bin/bash"
/nix/store/7lf3asc6cg5j6nzy016dyinalmgbhskx-password-store-1.7.2/bin/pass: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/bkjfiwh7v0gbxfrynvm9xzj2h0xid604-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/7lf3asc6cg5j6nzy016dyinalmgbhskx-password-store-1.7.2...
/nix/store/7lf3asc6cg5j6nzy016dyinalmgbhskx-password-store-1.7.2

andir added a commit to andir/nixpkgs that referenced this pull request Jun 17, 2018
@andir
pass: 1.7.1 -> 1.7.2
3e4f183 
This addresses some issues regarding CVE-2018-12356. There is a
annoucement for that version on the password-store ML [1] which goes
into details.

This is more or less a backport of NixOS#42049 which couldn't be
cherry-picked due to larger changes in the pass expression.

[1] https://lists.zx2c4.com/pipermail/password-store/2018-June/003308.html
@andir andir mentioned this pull request Jun 17, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ciil @lukateras @GrahamcOfBorg