pythonPackages.python-forecastio: init at 1.4.0 #42052

makefu · 2018-06-14T21:50:10Z

Motivation for this change

add the python package to get the darksky home-assistant module to work.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/) - works with home-assistant
Fits CONTRIBUTING.md.

ryantm · 2018-06-15T00:50:42Z

@GrahamcOfBorg build python2.pkgs.python-forecastio python3.pkgs.python-forecastio

GrahamcOfBorg · 2018-06-15T00:51:33Z

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.python-forecastio, python3.pkgs.python-forecastio

Partial log (click to expand)

forecastio/__init__.py                                      1      0   100%
forecastio/api.py                                          25     18    28%
forecastio/models.py                                       85     61    28%
forecastio/utils.py                                         9      3    67%
---------------------------------------------------------------------------
TOTAL                                                   29175  21648    26%
----------------------------------------------------------------------
Ran 0 tests in 0.214s

OK

GrahamcOfBorg · 2018-06-15T00:51:34Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.python-forecastio, python3.pkgs.python-forecastio

Partial log (click to expand)

requests/status_codes.py                                    8      0   100%
requests/structures.py                                     40     19    52%
requests/utils.py                                         400    336    16%
six.py                                                    450    210    53%
---------------------------------------------------------------------------
TOTAL                                                   29011  21509    26%
----------------------------------------------------------------------
Ran 0 tests in 0.272s

OK

GrahamcOfBorg · 2018-06-15T02:15:21Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.python-forecastio, python3.pkgs.python-forecastio

Partial log (click to expand)

requests/sessions.py                                      270    219    19%
requests/status_codes.py                                    8      0   100%
requests/structures.py                                     40     19    52%
requests/utils.py                                         400    336    16%
---------------------------------------------------------------------------
TOTAL                                                   29011  21509    26%
----------------------------------------------------------------------
Ran 0 tests in 0.968s

OK

ryantm · 2018-06-15T03:43:36Z

pkgs/servers/home-assistant/component-packages.nix

@@ -766,7 +766,7 @@
    "sensor.cups" = ps: with ps; [ pycups ];
    "sensor.currencylayer" = ps: with ps; [  ];
    "sensor.daikin" = ps: with ps; [  ];
-    "sensor.darksky" = ps: with ps; [  ];
+    "sensor.darksky" = ps: with ps; [ python-forecastio ];


Was this generated by parse-requirements.py? The top of the file says "do not edit".

oh oh :D i will look into it

I ran the command, however it was unable to detect the new dependency. now sure what to touch to make it work.
The package is called python-forecastio and will be installed with pip install python-forecastio. (see https://github.com/ZeevG/python-forecast.io )
can you check the parse-requirements.py package what went wrong there?

https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/sensor/darksky.py#L22 requires it

exactly, but how can i get the parse-requirements.py to find this requirement and add it automatically to the list of components?

cc @peterhoeg @dotlambda

FRidh · 2018-06-23T16:03:44Z

pkgs/servers/home-assistant/component-packages.nix

@@ -766,7 +766,7 @@
    "sensor.cups" = ps: with ps; [ pycups ];
    "sensor.currencylayer" = ps: with ps; [  ];
    "sensor.daikin" = ps: with ps; [  ];
-    "sensor.darksky" = ps: with ps; [  ];
+    "sensor.darksky" = ps: with ps; [ python-forecastio ];


This needs to be a separate commit.

as discussed above, this should be done somehow automatically by the update script but it doesn't for some reason

I have just tried running the parse-requirements.py script here and it works perfectly fine. In addition to updating the darksky sensor component it also updates the weather component as expected. What happens when you run it?

As mentioned by @FRidh that needs to go into a separate commit.

parse-requirements.py works for me as well. You should however rebase onto latest master, where Home Assistant was updated to 0.72.0.

dotlambda · 2018-06-25T13:48:03Z

pkgs/development/python-modules/python-forecastio/default.nix

+  propagatedBuildInputs = [ requests responses ];
+
+  checkPhase = ''
+    nosetests --with-coverage


You should be able to just drop --with-coverage and the coverage dependency above.

dotlambda · 2018-06-25T13:48:26Z

pkgs/development/python-modules/python-forecastio/default.nix

+
+  };
+
+  checkInputs = [ nose coverage responses ];


no need for responses here as it's in propagatedBuildInputs

makefu · 2018-06-25T23:16:48Z

i've added the changes requested, rebased onto latest master and i've put the regenerated component-packages into a separate commit.

GrahamcOfBorg · 2018-06-25T23:48:56Z

Success on x86_64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

copying path '/nix/store/gpfvffqn818p6a7xikk8rqj7s42q6kpy-python3.6-requests-2.18.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/w6mg8x1vpf9jm0pvggk96sdqi6vpjc1d-python3.6-home-assistant-frontend-20180622.1' from 'https://cache.nixos.org'...
copying path '/nix/store/ndv6m25bhs4p3jab75dbi0cx6r9h4ay7-python3.6-astral-1.6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/ricrxbf07nvb1b9q03fwj573sw01v3vq-python3.6-voluptuous-0.11.1' from 'https://cache.nixos.org'...
copying path '/nix/store/3iwqzvrpi4k9h0wkjfvhhmx6i2bkkqwc-python3.6-yarl-1.2.6' from 'https://cache.nixos.org'...
copying path '/nix/store/45993sfl15lkq626rwdcmhrpckxs0kn6-python3.6-voluptuous-serialize-2018-03-10' from 'https://cache.nixos.org'...
copying path '/nix/store/y0fjdr68b9i4j2fxfj0fiwmc4s5gq0s3-python3.6-aiohttp-3.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/jzg5b93y54pxs08pkf5s0qfbbgqxl4h1-python3.6-aiohttp-cors-0.7.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ysv8yw8q1gppyrflvyqv6r22gl41i5cz-homeassistant-0.72.0' from 'https://cache.nixos.org'...
/nix/store/ysv8yw8q1gppyrflvyqv6r22gl41i5cz-homeassistant-0.72.0

GrahamcOfBorg · 2018-06-25T23:49:20Z

Success on aarch64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

copying path '/nix/store/8jil5isssm8p75kraqxm4b5by21pqhhg-python3.6-home-assistant-frontend-20180622.1' from 'https://cache.nixos.org'...
copying path '/nix/store/3jqvlg5q3mjjv7ynm033g4ld4dya10wf-python3.6-cryptography-2.2.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/0n3bfis3zzylmgj4qw92mknjdxvzglcj-python3.6-pyOpenSSL-18.0.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/0la429g5ls1ry6k4i07sv4846gm5az01-python3.6-aiohttp-3.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/nw5p35qxrvflmk8kl15rriip0zpss946-python3.6-urllib3-1.23' from 'https://cache.nixos.org'...
copying path '/nix/store/rx843h9kw58p8gwnyrxgm1vbv20bcvj0-python3.6-requests-2.18.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/28hbw8sw5k9jlqjzs4p4z9m5c00hn3kl-python3.6-aiohttp-cors-0.7.0' from 'https://cache.nixos.org'...
copying path '/nix/store/k5gd6v393m301a0svzca2pbvfd0mim8p-python3.6-astral-1.6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/28skddbwca5cvzil5nv0fpkj20vwl9h5-homeassistant-0.72.0' from 'https://cache.nixos.org'...
/nix/store/28skddbwca5cvzil5nv0fpkj20vwl9h5-homeassistant-0.72.0

GrahamcOfBorg · 2018-06-25T23:56:38Z

Success on x86_64-darwin (full log)

Attempted: home-assistant

Partial log (click to expand)

tests/components/test_init.py ................                           [ 67%]
tests/components/test_introduction.py .                                  [ 68%]
tests/components/test_logger.py ......                                   [ 71%]
tests/components/test_script.py .....                                    [ 75%]
tests/components/test_shell_command.py ........                          [ 80%]
tests/components/test_system_log.py ................                     [ 90%]
tests/components/test_websocket_api.py ................                  [100%]

========================== 160 passed in 4.18 seconds ==========================
/nix/store/l4rzhxy8rl4rwpxy208883q9dlys3wf2-homeassistant-0.72.0

peterhoeg · 2018-06-26T04:10:19Z

There are 2 changes to the components file but one of them is in the wrong commit.

makefu · 2018-06-26T06:52:40Z

@peterhoeg you are right, i fixed that

dotlambda · 2018-06-26T06:59:18Z

The file is still changed by the first commit.

GrahamcOfBorg · 2018-06-26T07:15:39Z

Success on x86_64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

/nix/store/ysv8yw8q1gppyrflvyqv6r22gl41i5cz-homeassistant-0.72.0

GrahamcOfBorg · 2018-06-26T07:15:44Z

Success on aarch64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

copying path '/nix/store/0la429g5ls1ry6k4i07sv4846gm5az01-python3.6-aiohttp-3.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/rxba3z7k6gfs80wbqf9rxib108kr121n-python3.6-cffi-1.11.5-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/28hbw8sw5k9jlqjzs4p4z9m5c00hn3kl-python3.6-aiohttp-cors-0.7.0' from 'https://cache.nixos.org'...
copying path '/nix/store/3jqvlg5q3mjjv7ynm033g4ld4dya10wf-python3.6-cryptography-2.2.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/0n3bfis3zzylmgj4qw92mknjdxvzglcj-python3.6-pyOpenSSL-18.0.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/nw5p35qxrvflmk8kl15rriip0zpss946-python3.6-urllib3-1.23' from 'https://cache.nixos.org'...
copying path '/nix/store/rx843h9kw58p8gwnyrxgm1vbv20bcvj0-python3.6-requests-2.18.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/k5gd6v393m301a0svzca2pbvfd0mim8p-python3.6-astral-1.6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/28skddbwca5cvzil5nv0fpkj20vwl9h5-homeassistant-0.72.0' from 'https://cache.nixos.org'...
/nix/store/28skddbwca5cvzil5nv0fpkj20vwl9h5-homeassistant-0.72.0

GrahamcOfBorg · 2018-06-26T07:15:56Z

Success on x86_64-darwin (full log)

Attempted: home-assistant

Partial log (click to expand)

copying path '/nix/store/byh2f1a56q815idp9qx0ww0r19hncp79-python3.6-urllib3-1.23' from 'https://cache.nixos.org'...
copying path '/nix/store/i11ykrgzc21kpd85yg11ncmr3d5bzmhq-python3.6-voluptuous-0.11.1' from 'https://cache.nixos.org'...
copying path '/nix/store/n9wpballa9lsnds6sf2bl719zkbnxsa1-python3.6-requests-2.18.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/kk740ril7kwvb03h60w3yd8xfb81jnxn-python3.6-voluptuous-serialize-2018-03-10' from 'https://cache.nixos.org'...
copying path '/nix/store/x9gbccymiycqrbgycwr43lvg4f2vyh3d-python3.6-astral-1.6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/am909g0rl8a02md58hyx5qr6xbdh426s-python3.6-yarl-1.2.6' from 'https://cache.nixos.org'...
copying path '/nix/store/bddc96p86iwqlixizfbyprvwm4aslf3n-python3.6-aiohttp-3.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/alkbdnlxv9l4q9kjpf33njsma32fz6mw-python3.6-aiohttp-cors-0.7.0' from 'https://cache.nixos.org'...
copying path '/nix/store/l4rzhxy8rl4rwpxy208883q9dlys3wf2-homeassistant-0.72.0' from 'https://cache.nixos.org'...
/nix/store/l4rzhxy8rl4rwpxy208883q9dlys3wf2-homeassistant-0.72.0

FRidh

as @dotlambda mentioned

adds python-forecastio to weather.darksky

makefu · 2018-06-26T16:38:15Z

... sorry for the fuckup, this is what happens when you try to manually revert changes in a commit instead of knowing the correct git command.
it should be ok now .

GrahamcOfBorg · 2018-06-26T16:57:44Z

Success on x86_64-darwin (full log)

Attempted: home-assistant

Partial log (click to expand)

/nix/store/l4rzhxy8rl4rwpxy208883q9dlys3wf2-homeassistant-0.72.0

GrahamcOfBorg · 2018-06-26T16:57:51Z

Success on x86_64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

copying path '/nix/store/45993sfl15lkq626rwdcmhrpckxs0kn6-python3.6-voluptuous-serialize-2018-03-10' from 'https://cache.nixos.org'...
copying path '/nix/store/wik3qd5hr2jz414v2vw1vbfqy4b3n870-python3.6-urllib3-1.23' from 'https://cache.nixos.org'...
copying path '/nix/store/li27hpkvvc3z3jbya38835wqf3lrcpci-python3.6-user-agents-1.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/gpfvffqn818p6a7xikk8rqj7s42q6kpy-python3.6-requests-2.18.4-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/y0fjdr68b9i4j2fxfj0fiwmc4s5gq0s3-python3.6-aiohttp-3.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/w6mg8x1vpf9jm0pvggk96sdqi6vpjc1d-python3.6-home-assistant-frontend-20180622.1' from 'https://cache.nixos.org'...
copying path '/nix/store/ndv6m25bhs4p3jab75dbi0cx6r9h4ay7-python3.6-astral-1.6.1' from 'https://cache.nixos.org'...
copying path '/nix/store/jzg5b93y54pxs08pkf5s0qfbbgqxl4h1-python3.6-aiohttp-cors-0.7.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ysv8yw8q1gppyrflvyqv6r22gl41i5cz-homeassistant-0.72.0' from 'https://cache.nixos.org'...
/nix/store/ysv8yw8q1gppyrflvyqv6r22gl41i5cz-homeassistant-0.72.0

GrahamcOfBorg · 2018-06-26T16:58:01Z

Success on aarch64-linux (full log)

Attempted: home-assistant

Partial log (click to expand)

/nix/store/28skddbwca5cvzil5nv0fpkj20vwl9h5-homeassistant-0.72.0

dotlambda · 2018-06-26T18:23:29Z

Thanks @makefu! That Dark Sky API seems to be interesting indeed.

makefu requested a review from FRidh as a code owner June 14, 2018 21:50

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 14, 2018

ryantm reviewed Jun 15, 2018

View reviewed changes

FRidh requested changes Jun 23, 2018

View reviewed changes

FRidh requested a review from dotlambda June 23, 2018 16:03

dotlambda reviewed Jun 25, 2018

View reviewed changes

makefu force-pushed the pkgs/python-forecastio/init branch from 8abb7b0 to f8d30b1 Compare June 25, 2018 23:15

makefu force-pushed the pkgs/python-forecastio/init branch from f8d30b1 to e5ff063 Compare June 26, 2018 06:52

FRidh approved these changes Jun 26, 2018

View reviewed changes

FRidh requested changes Jun 26, 2018

View reviewed changes

makefu added 2 commits June 26, 2018 18:35

pythonPackages.python-forecastio: init at 1.4.0

ecac42b

home-assistant: regenerate component-packages

5db01c5

adds python-forecastio to weather.darksky

makefu force-pushed the pkgs/python-forecastio/init branch from e5ff063 to 5db01c5 Compare June 26, 2018 16:36

dotlambda merged commit 352995d into NixOS:master Jun 26, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.python-forecastio: init at 1.4.0 #42052

pythonPackages.python-forecastio: init at 1.4.0 #42052

makefu commented Jun 14, 2018

ryantm commented Jun 15, 2018

GrahamcOfBorg commented Jun 15, 2018

GrahamcOfBorg commented Jun 15, 2018

GrahamcOfBorg commented Jun 15, 2018

ryantm Jun 15, 2018

makefu Jun 15, 2018

makefu Jun 15, 2018

ryantm Jun 15, 2018

makefu Jun 15, 2018

ryantm Jun 15, 2018

FRidh Jun 23, 2018

makefu Jun 23, 2018

peterhoeg Jun 25, 2018

dotlambda Jun 25, 2018

dotlambda Jun 25, 2018

dotlambda Jun 25, 2018

makefu commented Jun 25, 2018

GrahamcOfBorg commented Jun 25, 2018

GrahamcOfBorg commented Jun 25, 2018

GrahamcOfBorg commented Jun 25, 2018

peterhoeg commented Jun 26, 2018

makefu commented Jun 26, 2018

dotlambda commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

FRidh left a comment

makefu commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

dotlambda commented Jun 26, 2018

pythonPackages.python-forecastio: init at 1.4.0 #42052

pythonPackages.python-forecastio: init at 1.4.0 #42052

Conversation

makefu commented Jun 14, 2018

Motivation for this change

Things done

ryantm commented Jun 15, 2018

GrahamcOfBorg commented Jun 15, 2018

GrahamcOfBorg commented Jun 15, 2018

GrahamcOfBorg commented Jun 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

makefu commented Jun 25, 2018

GrahamcOfBorg commented Jun 25, 2018

GrahamcOfBorg commented Jun 25, 2018

GrahamcOfBorg commented Jun 25, 2018

peterhoeg commented Jun 26, 2018

makefu commented Jun 26, 2018

dotlambda commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

FRidh left a comment

Choose a reason for hiding this comment

makefu commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

GrahamcOfBorg commented Jun 26, 2018

dotlambda commented Jun 26, 2018