Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.gapi_ocaml: minor cleaning #41197

Merged
merged 2 commits into from May 31, 2018
Merged

ocamlPackages.gapi_ocaml: minor cleaning #41197

merged 2 commits into from May 31, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented May 29, 2018

Motivation for this change

Remove redundancies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 31, 2018

@GrahamcOfBorg build ocamlPackages.gapi_ocaml ocamlPackages_4_02.async_ssl google-drive-ocamlfuse

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.gapi_ocaml, ocamlPackages_4_02.async_ssl, google-drive-ocamlfuse

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xam9wdxk9x3nbvzlzzj0gc0jbna86f54-ocaml-async_ssl-113.33.07
shrinking /nix/store/xam9wdxk9x3nbvzlzzj0gc0jbna86f54-ocaml-async_ssl-113.33.07/lib/ocaml/4.02.3/site-lib/async_ssl/async_ssl_bindings.cmxs
shrinking /nix/store/xam9wdxk9x3nbvzlzzj0gc0jbna86f54-ocaml-async_ssl-113.33.07/lib/ocaml/4.02.3/site-lib/async_ssl/async_ssl.cmxs
shrinking /nix/store/xam9wdxk9x3nbvzlzzj0gc0jbna86f54-ocaml-async_ssl-113.33.07/lib/ocaml/4.02.3/site-lib/async_ssl/dllasync_ssl_stubs.so
patching script interpreter paths in /nix/store/xam9wdxk9x3nbvzlzzj0gc0jbna86f54-ocaml-async_ssl-113.33.07
checking for references to /build in /nix/store/xam9wdxk9x3nbvzlzzj0gc0jbna86f54-ocaml-async_ssl-113.33.07...
/nix/store/w5ra5hcmxm6bzkyrqaj464sl7h49n2bj-gapi-ocaml-0.3.6
/nix/store/xam9wdxk9x3nbvzlzzj0gc0jbna86f54-ocaml-async_ssl-113.33.07
/nix/store/hshb1cj2wi1k0n6bwa6qa2m59fhaq46g-google-drive-ocamlfuse-0.6.25

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.gapi_ocaml, ocamlPackages_4_02.async_ssl

The following builds were skipped because they don't evaluate on x86_64-darwin: google-drive-ocamlfuse

Partial log (click to expand)

_build/src/async_ssl.cmxa        => /nix/store/iq0x4s3a87skxv60xqbm40wbqf1cymi9-ocaml-async_ssl-113.33.07/lib/ocaml/4.02.3/site-lib/async_ssl/async_ssl.cmxa
_build/src/async_ssl.cma         => /nix/store/iq0x4s3a87skxv60xqbm40wbqf1cymi9-ocaml-async_ssl-113.33.07/lib/ocaml/4.02.3/site-lib/async_ssl/async_ssl.cma
_build/src/async_ssl.cmi         => /nix/store/iq0x4s3a87skxv60xqbm40wbqf1cymi9-ocaml-async_ssl-113.33.07/lib/ocaml/4.02.3/site-lib/async_ssl/async_ssl.cmi
_build/src/async_ssl.cmt         => /nix/store/iq0x4s3a87skxv60xqbm40wbqf1cymi9-ocaml-async_ssl-113.33.07/lib/ocaml/4.02.3/site-lib/async_ssl/async_ssl.cmt
_build/src/libasync_ssl_stubs.a  => /nix/store/iq0x4s3a87skxv60xqbm40wbqf1cymi9-ocaml-async_ssl-113.33.07/lib/ocaml/4.02.3/site-lib/async_ssl/libasync_ssl_stubs.a
_build/src/dllasync_ssl_stubs.so => /nix/store/iq0x4s3a87skxv60xqbm40wbqf1cymi9-ocaml-async_ssl-113.33.07/lib/ocaml/4.02.3/site-lib//async_ssl/dllasync_ssl_stubs.so
post-installation fixup
patching script interpreter paths in /nix/store/iq0x4s3a87skxv60xqbm40wbqf1cymi9-ocaml-async_ssl-113.33.07
/nix/store/3h14rbh9rj49qwrm5kg111pd3xglkjg3-gapi-ocaml-0.3.6
/nix/store/iq0x4s3a87skxv60xqbm40wbqf1cymi9-ocaml-async_ssl-113.33.07

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ocamlPackages.gapi_ocaml, ocamlPackages_4_02.async_ssl, google-drive-ocamlfuse

Partial log (click to expand)

cannot build derivation '/nix/store/297vpcp02ps3flzcp49cfxrv0i075abx-ocaml-ppx_jane-113.33.03.drv': 25 dependencies couldn't be built
cannot build derivation '/nix/store/1582rksf4mqdaba2drmccc3qc65f1j7n-ocaml-core_kernel-113.33.03.drv': 17 dependencies couldn't be built
cannot build derivation '/nix/store/6w3n21waiqa8mi27xysbb8vhl2lwk8x8-ocaml-async_kernel-113.33.03.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/j3sjqh5an5dfgchhs0j8mmrmx0912mvn-ocaml-core-113.33.03.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/bf94d0jmal4124cazn5cd19w9w2mfppf-ocaml-async_rpc_kernel-113.33.03.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/j31hxxrfpw0q11l6xfky16005p75ym82-ocaml-async_unix-113.33.03.drv': 14 dependencies couldn't be built
cannot build derivation '/nix/store/rrxfc2pwdl6xbkgy80438s77nddjr7wg-ocaml-async_extra-113.33.03.drv': 16 dependencies couldn't be built
cannot build derivation '/nix/store/gsbxanfg7vysvv2ckpyk7qbf3pcd8x92-ocaml-async-113.33.03.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/r01c13jscsvk68y0wsjy92baq30z9g0w-ocaml-async_ssl-113.33.07.drv': 14 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/3i9z7dbb49as8anj8crvbm9h3l0bg0jj-google-drive-ocamlfuse-0.6.25.drv', '/nix/store/kf92drgzmj4l5mm4ihfxg80l614fjjm3-gapi-ocaml-0.3.6.drv', '/nix/store/r01c13jscsvk68y0wsjy92baq30z9g0w-ocaml-async_ssl-113.33.07.drv' failed

@xeji
Copy link
Contributor

xeji commented May 31, 2018

aarch64 failure looks unrelated.

@xeji xeji merged commit 41649f5 into NixOS:master May 31, 2018
@vbgl vbgl deleted the ocaml-clean-201805 branch June 1, 2018 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @xeji @GrahamcOfBorg