Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] pythonPackages.elasticsearch[-dsl] 5.x and 6.x #41201

Closed
wants to merge 5 commits into from
Closed

[WIP] pythonPackages.elasticsearch[-dsl] 5.x and 6.x #41201

wants to merge 5 commits into from

Conversation

flokli
Copy link
Contributor

@flokli flokli commented May 29, 2018

Motivation for this change

This touches the elasticsearch and elasticsearch-dsl python modules in nixpkgs, bumping and splitting into 5.x and 6.x verisons, while providing aliases for backwards compatibility.
Different versions are required as the bindings are specific to the version of the elasticsearch they connect to…

Tests are currently disabled, as they try to connect to a local elasticsearch cluster.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@flokli
pythonPackages.elasticsearch: alias to elasticsearch_6, move from def…
dfe3650 
…ault.nix to 6.x.nix
@flokli
pythonPackages.elasticsearch_6: remove test inputs from expression
57f9c54 
They would belong into checkInputs anyhow. As we disable tests, because
they wipe out local data, strip them completely.
@flokli
pythonPackages.elasticsearch-dsl_6: 0.0.9 -> 6.1.0, move into 6.x.nix…
ee109c5 
…, add aliases

strip test dependencies, as they're broken anyways and require a local
instance of elasticsearch
@flokli
pythonPackages.elasticsearch_5: init at 5.5.2
7386db7
@flokli
pythonPackages.elasticsearch-dsl_5: init at 5.4.0
9f63143
@flokli flokli requested a review from FRidh as a code owner May 29, 2018 11:30
@flokli
Copy link
Contributor Author

flokli commented Apr 8, 2019

superseded by #44389 and #44339.

@flokli flokli closed this Apr 8, 2019
@flokli flokli deleted the elasticsearch branch April 8, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: work-in-progress 6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @joachifm @GrahamcOfBorg