Fix GameUI flag value regression introduced by a78659e

nerzhul · nerzhul · commit 75aa41c6de12 · 2018-05-29T08:34:09.000+02:00
Added more strong unittests on that part to prevent future regression
diff --git a/src/client/gameui.cpp b/src/client/gameui.cpp
@@ -189,8 +189,6 @@ void GameUI::update(const RunStats &stats, Client *client, MapDrawControl *draw_
 void GameUI::initFlags()
 {
 	m_flags = GameUI::Flags();
-	m_flags.show_chat = true;
-	m_flags.show_hud = true;
 	m_flags.show_debug = g_settings->getBool("show_debug");
 }
 
diff --git a/src/client/gameui.h b/src/client/gameui.h
@@ -54,9 +54,9 @@ class GameUI
 	{
 		bool show_chat = true;
 		bool show_hud = true;
-		bool show_minimap = true;
+		bool show_minimap = false;
 		bool show_debug = true;
-		bool show_profiler_graph = true;
+		bool show_profiler_graph = false;
 	};
 
 	void init();
diff --git a/src/unittest/test_gameui.cpp b/src/unittest/test_gameui.cpp
@@ -48,9 +48,18 @@ void TestGameUI::runTests(IGameDef *gamedef)
 void TestGameUI::testInit()
 {
 	GameUI gui{};
+	// Ensure flags on GameUI init
+	UASSERT(gui.getFlags().show_chat)
+	UASSERT(gui.getFlags().show_hud)
+	UASSERT(!gui.getFlags().show_minimap)
+	UASSERT(!gui.getFlags().show_profiler_graph)
+	
+	// And after the initFlags init stage
 	gui.initFlags();
 	UASSERT(gui.getFlags().show_chat)
 	UASSERT(gui.getFlags().show_hud)
+	UASSERT(!gui.getFlags().show_minimap)
+	UASSERT(!gui.getFlags().show_profiler_graph)
 
 	// @TODO verify if we can create non UI nulldevice to test this function
 	// gui.init();

Original file line number	Diff line number	Diff line change
`@@ -189,8 +189,6 @@ void GameUI::update(const RunStats &stats, Client client, MapDrawControl draw_`
`189`	`189`	`void GameUI::initFlags()`
`190`	`190`	`{`
`191`	`191`	`m_flags = GameUI::Flags();`
`192`		`- m_flags.show_chat = true;`
`193`		`- m_flags.show_hud = true;`
`194`	`192`	`m_flags.show_debug = g_settings->getBool("show_debug");`
`195`	`193`	`}`
`196`	`194`