New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove some format hardenings #41192
Conversation
75b5d0b
to
486948f
Compare
Success on x86_64-linux (full log) Attempted: a52dec, libgdiplus, tinyxml Partial log (click to expand)
|
@GrahamcOfBorg build linuxPackages.perf haskellPackages.ghc802 |
Success on x86_64-linux (full log) Attempted: linuxPackages.perf The following builds were skipped because they don't evaluate on x86_64-linux: haskellPackages.ghc802 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: linuxPackages.perf The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.ghc802 Partial log (click to expand)
|
@GrahamcOfBorg build haskell.compiler.ghc802 |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghc802 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: haskell.compiler.ghc802 Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: a52dec, libgdiplus, tinyxml Partial log (click to expand)
|
|
How about |
One test still fails :(
before squashing was: "disable pic hardening on i686, else tests will fail"
486948f
to
29757f3
Compare
libgdiplus
Identical change, rebased.
How about `haskell.packages.ghc842.ghc`?
Likely related, fixed.
|
Success on aarch64-linux (full log) Attempted: a52dec, linuxPackages.perf, tinyxml The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghc802, haskell.compiler.ghc842 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: a52dec, haskell.compiler.ghc802, haskell.compiler.ghc842, linuxPackages.perf, tinyxml Partial log (click to expand)
|
I committed a246b6e6f8a33622d0be001391a9087820030134 and 8d36f159fa3dcdb2b8f4872787a4bf67748fd7db to the EDIT: I needed two attempts to get the hyperlinks to the commits right. |
Okay. Do you want me to do anything else with this?
Ofborg clearly shows that this doesn't make things worse, so I would just merge so that master would hopefully start to build again.
|
Motivation for this change
Fixing fallout from #28029 and continuing #39463.
Things done