Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pdfminer: replacing pdfminer with pdfminer_six #41207

Merged
merged 2 commits into from May 29, 2018
Merged

pythonPackages.pdfminer: replacing pdfminer with pdfminer_six #41207

merged 2 commits into from May 29, 2018

Conversation

PsyanticY
Copy link
Contributor

Motivation for this change

PDFMiner.six is a fork of PDFMiner using six for Python 2+3 compatibility. I think it safe to remove the old pdfminer and only keep pdfminer.six (tested building weboob which as far as i know the only package that depends on pdfminer using the new pdfminer_six and it was successful)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@PsyanticY PsyanticY requested a review from FRidh as a code owner May 29, 2018 12:42
@FRidh
Copy link
Member

FRidh commented May 29, 2018

@GrahamcOfBorg build python2.pkgs.pdfminer python3.pkgs.pdfminer

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pdfminer, python3.pkgs.pdfminer

Partial log (click to expand)

tests/test_tools_dumppdf.py ......                                       [ 78%]
tests/test_tools_dumppdf.py ......                                       [ 78%]
tests/test_tools_pdf2txt.py ........                                     [100%]

========================== 38 passed in 22.00 seconds ==========================
tests/test_tools_pdf2txt.py ........                                     [100%]

========================== 38 passed in 23.09 seconds ==========================
/nix/store/mxjhf58wagzavwd8fyvjryrc38rw6v4n-python2.7-pdfminer_six-20170720
/nix/store/aiqhvbj3v0am06p8sqrkzdcphbml343x-python3.6-pdfminer_six-20170720

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pdfminer, python3.pkgs.pdfminer

Partial log (click to expand)

tests/test_tools_dumppdf.py ......                                       [ 78%]
tests/test_tools_dumppdf.py ......                                       [ 78%]
tests/test_tools_pdf2txt.py ........                                     [100%]

========================= 38 passed in 174.15 seconds ==========================
tests/test_tools_pdf2txt.py ........                                     [100%]

========================= 38 passed in 181.20 seconds ==========================
/nix/store/1ikx81yi802pwysj960i3ajxdixiiypb-python2.7-pdfminer_six-20170720
/nix/store/4jhynhd3ngx3s6my8s1sr96vgh1kff15-python3.6-pdfminer_six-20170720

@FRidh FRidh merged commit 0450c7f into NixOS:master May 29, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2.pkgs.pdfminer, python3.pkgs.pdfminer

Partial log (click to expand)


tests/test_pdfminer_ccitt.py ................                            [ 42%]
tests/test_pdfminer_crypto.py ......                                     [ 57%]
tests/test_pdfminer_psparser.py ..                                       [ 63%]
tests/test_tools_dumppdf.py ......                                       [ 78%]
tests/test_tools_pdf2txt.py ........                                     [100%]

========================== 38 passed in 24.38 seconds ==========================
/nix/store/dyh0bi12l3jzjncd1yqp52qxsv6czggw-python2.7-pdfminer_six-20170720
/nix/store/bzcj183f22vqmw4yyv55sq6dz9f6nvlq-python3.6-pdfminer_six-20170720

@PsyanticY PsyanticY deleted the pdfminer_six branch May 29, 2018 16:06
@flokli flokli mentioned this pull request May 29, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PsyanticY @FRidh @GrahamcOfBorg