Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gtk2 from gnome3 attrset #41209

Merged
merged 3 commits into from May 29, 2018
Merged

Remove gtk2 from gnome3 attrset #41209

merged 3 commits into from May 29, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented May 29, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: signal-desktop

Partial log (click to expand)

these derivations will be built:
  /nix/store/6l5bsvwdlydj88nhbxlhz7hvvj5n8da2-signal-desktop-1.11.0.drv
building '/nix/store/6l5bsvwdlydj88nhbxlhz7hvvj5n8da2-signal-desktop-1.11.0.drv'...
unpacking sources
installing
/nix/store/4vak9vccj9lf7lvxvq08ff6kfnrammda-signal-desktop-1.11.0

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: signal-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: signal-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@orivej orivej merged commit 59f86ab into NixOS:master May 29, 2018
@jtojnar jtojnar deleted the gnome-no-gtk2 branch May 29, 2018 13:45
@GrahamcOfBorg GrahamcOfBorg removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 29, 2018
@jtojnar jtojnar mentioned this pull request May 29, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @GrahamcOfBorg @orivej