Fix .htaccess files for Apache 2.4 (and 2.2) #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer to module by suitable file name (mod_*.c). Test for mod_authz_core.c (instead of mod_authz_host.c) to properly detect Apache 2.4 and avoid false positive for Apache 2.2.
|
Although functional, this is still a hack. Is there a reason why we're not using the Apache module mod_version? It was included in all distributions I've used the past 10(?) years. Are there known cases where it isn't included? It immediately makes it clear what the if statement does: Edit: Just realised I might have better posted this in the accompanying issue. I'll post my question there ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to module by suitable file name (mod_*.c).
Test for mod_authz_core.c (instead of mod_authz_host.c) to properly
detect Apache 2.4 and avoid false positive for Apache 2.2.
Closes #2428.