Fix 1117: Use realpath in stage1 Darwin os_self_exe_path #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: ziglang#1117 The macOS stage1 Zig compiler should look in Zig's real absolute path for the Zig stdlib, but os_self_exe_path looked in its relative path, which caused a symlinked Zig to be unable to find the stdlib. This patch fixes the issue by resolving the relative path to the real path using _realpath()_ before copying to the output path.
|
This implementation uses variable-length arrays, which are NOT in the ISO C++ standard, but are supported by clang and gcc, which is what macOS uses. I'll tweak this to use the |
|
Reopened as #1128. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1117
The macOS stage1 Zig compiler should look in Zig's real absolute path
for the Zig stdlib, but os_self_exe_path looked in its relative path,
which caused a symlinked Zig to be unable to find the stdlib.
This patch fixes the issue by resolving the relative path to the real
path using realpath() before copying to the output path.