Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mupf to maintainer-list.nix #42111

Closed
wants to merge 1 commit into from
Closed

Add mupf to maintainer-list.nix #42111

wants to merge 1 commit into from

Conversation

mupfdev
Copy link

@mupfdev mupfdev commented Jun 16, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member

nlewo commented Jun 16, 2018

It would be more suitable to put this commit in a PR that also contains a package change (new package or package update). Do you plan to submit another PR with such kind of changes?

@mupfdev
Copy link
Author

mupfdev commented Jun 17, 2018

Sorry for the inconvenience, it was the first time I made a change using GitHub's web editor. I am currently planning to become the new maintainer of an outdated package and have been told that I have to add myself to this list first. I don't plan to submit another PR like this.

@mupfdev mupfdev closed this Jun 17, 2018
@nlewo
Copy link
Member

nlewo commented Jun 17, 2018

In this case, when you will submit a PR with an update of this outdated package, you could also add yourself in the nixpkgs maintainer list and in the meta.maintainer attributes of the package.
Do not hesitate to ping for any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants