Fix examples in Formatting and Parsing Time #6208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
approved these changes
Jun 17, 2018
bcardiff
reviewed
Jun 17, 2018
src/time.cr
Outdated
| @@ -127,15 +127,15 @@ require "crystal/system/time" | |||
| # The method `#to_s` formats the date-time according to a specified pattern. | |||
| # | |||
| # ``` | |||
| # time = Time.utc(2015, 10, 12, 10, 30, 00) | |||
| # time = Time.utc(2015, 10, 12, 10, 30, 0) | |||
| # time.to_s("%Y-%m-%d %H:%m:%s %Z") # => "2015-10-12 10:30:00 +00:00" | |||
There was a problem hiding this comment.
This %Z also needs to be changed, right?
straight-shoota
approved these changes
Jun 18, 2018
Sija
reviewed
Jun 18, 2018
| # ``` | ||
| # | ||
| # Similarly, `Time.parse` is used to construct a `Time` instance from date-time | ||
| # information in a string, according to a specified pattern: | ||
| # | ||
| # ``` | ||
| # Time.parse("2015-10-12 10:30:00 +00:00", "%Y-%m-%d %H:%m:%s %Z") | ||
| # Time.parse("2015-10-12 10:30:00 +00:00", "%Y-%m-%d %H:%M:%S %z") |
There was a problem hiding this comment.
No it doesn't needs to be %:z. This gives:
2015-10-12 10:30:00 +00:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6207
In the first example the
00causes this error:octal constants should be prefixed with 0oso the00itself and the code behind it got cut off so it looks like this in the docs right now: