Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vlc: Fixes build with fribidi version 1.0 #42130

Merged
merged 1 commit into from Jun 18, 2018
Merged

vlc: Fixes build with fribidi version 1.0 #42130

merged 1 commit into from Jun 18, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Jun 17, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jun 18, 2018

@GrahamcOfBorg build vlc

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: vlc

Partial log (click to expand)

make[1]: *** [Makefile:32: Media.o] Error 1
make[1]: Leaving directory '/build/live/liveMedia'
make: *** [Makefile:33: all] Error 2
100  3410    0  3410    0     0  18138      0 --:--:-- --:--:-- --:--:-- 18138
builder for '/nix/store/lmyzwzhdgryb69amh53rg2ziabwhhsds-live555-2018.02.28.drv' failed with exit code 2
copying path '/nix/store/fghbf07kxjwxn6fimb4hy6pfl9c4qkks-ffmpeg-3.4.2-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/slf0ir4s44hw8f42c1wd1f58hcbgkak6-ffmpeg-3.4.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/6c3f8k21yz75nmfqzlg5m3nmq8qmpmy9-samba-4.7.6-dev' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/fmi8x2fna7mlm40b2skx546l0hhjikfq-vlc-3.0.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/fmi8x2fna7mlm40b2skx546l0hhjikfq-vlc-3.0.3.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: vlc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vlc

Partial log (click to expand)

/nix/store/kpx81gm0k4068zwv6x7hw1rir43ajiz0-vlc-3.0.3/share/vlc/utils/gnome-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/kpx81gm0k4068zwv6x7hw1rir43ajiz0-vlc-3.0.3/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/kpx81gm0k4068zwv6x7hw1rir43ajiz0-vlc-3.0.3/share/vlc/utils/video-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/kpx81gm0k4068zwv6x7hw1rir43ajiz0-vlc-3.0.3/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/kpx81gm0k4068zwv6x7hw1rir43ajiz0-vlc-3.0.3/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/kpx81gm0k4068zwv6x7hw1rir43ajiz0-vlc-3.0.3/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/kpx81gm0k4068zwv6x7hw1rir43ajiz0-vlc-3.0.3/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/kpx81gm0k4068zwv6x7hw1rir43ajiz0-vlc-3.0.3...
postPatchMkspecs
/nix/store/kpx81gm0k4068zwv6x7hw1rir43ajiz0-vlc-3.0.3

@xeji
Copy link
Contributor

xeji commented Jun 18, 2018

aarch64 failure is in a dependency (live555) and unrelated to this PR.

@xeji xeji merged commit 1782b9e into NixOS:master Jun 18, 2018
@bkchr bkchr deleted the fix_vlc branch June 19, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @Mic92 @GrahamcOfBorg @xeji