Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serializable, remove version conditions #6209

Merged
merged 3 commits into from Jun 19, 2018
Merged

Serializable, remove version conditions #6209

merged 3 commits into from Jun 19, 2018

Conversation

kostya
Copy link
Contributor

@kostya kostya commented Jun 17, 2018

No description provided.

@kostya
Copy link
Contributor Author

kostya commented Jun 17, 2018

seems travis still use 0.24.2

@wooster0
Copy link
Contributor

wooster0 commented Jun 17, 2018 •
edited

What about also removing the TODO here: https://github.com/crystal-lang/crystal/blob/master/spec/std/object_spec.cr#L106 by using :property1?

@bcardiff
Copy link
Member

bcardiff commented Jun 18, 2018 •
edited

@kostya CI was recently updated. would you rebase the PR onto master?
Thank you for the housekeeping.

@sdogruyol sdogruyol merged commit 5c22fb3 into crystal-lang:master Jun 19, 2018
@RX14 RX14 added this to the 0.25.1 milestone Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib
Projects
None yet
Milestone
0.25.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kostya @wooster0 @bcardiff @jhass @straight-shoota @sdogruyol @RX14