python.pkgs.python-language-server: init at 0.18.0 #41061

Mic92 · 2018-05-24T23:32:07Z

Motivation for this change

I use the following snippet for the plugins (put it into environment.systemPackages for example).

(python3.withPackages(ps: [ps.pyls-mypy ps.pyls-isort ]))

and the following snippets in neovim:

let g:LanguageClient_serverCommands = {
     \ 'python': ['pyls']
     \ }

which is provided by the LanguageClient-neovim as shown in my dotfiles: https://github.com/Mic92/dotfiles/blob/master/nixpkgs-config/config.nix#L26

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2018-05-24T23:34:44Z

@GrahamcOfBorg build python.pkgs.python-language-server

GrahamcOfBorg · 2018-05-24T23:35:36Z

Success on x86_64-linux (full log)

Attempted: python.pkgs.python-language-server

Partial log (click to expand)

test/test_language_server.py               28      0   100%
test/test_uris.py                          17      2    88%
test/test_utils.py                         56      0   100%
test/test_workspace.py                     33      0   100%
-----------------------------------------------------------
TOTAL                                    2051    219    89%
Coverage HTML written to dir htmlcov

===================== 89 passed, 5 skipped in 6.44 seconds =====================
/nix/store/2b0y9mi9l7h4n7x1yykznljsmj47x0m5-python2.7-python-language-server-0.18.0

GrahamcOfBorg · 2018-05-24T23:35:39Z

Success on x86_64-darwin (full log)

Attempted: python.pkgs.python-language-server

Partial log (click to expand)

test/test_language_server.py               28      0   100%
test/test_uris.py                          17      2    88%
test/test_utils.py                         56      0   100%
test/test_workspace.py                     33      0   100%
-----------------------------------------------------------
TOTAL                                    2051    223    89%
Coverage HTML written to dir htmlcov

===================== 89 passed, 5 skipped in 4.75 seconds =====================
/nix/store/fqljfgw54v8zzija2jmw8qv8wsr0rrlc-python2.7-python-language-server-0.18.0

GrahamcOfBorg · 2018-05-24T23:36:14Z

Success on aarch64-linux (full log)

Attempted: python.pkgs.python-language-server

Partial log (click to expand)

test/test_language_server.py               28      0   100%
test/test_uris.py                          17      2    88%
test/test_utils.py                         56      0   100%
test/test_workspace.py                     33      0   100%
-----------------------------------------------------------
TOTAL                                    2051    220    89%
Coverage HTML written to dir htmlcov

==================== 89 passed, 5 skipped in 22.03 seconds =====================
/nix/store/ib68rbiflq5f6xmgw8cm63k1k0b3b7b1-python2.7-python-language-server-0.18.0

teto · 2018-05-25T04:03:32Z

Looks good. Closing this then #31180

Mic92 · 2018-05-25T08:24:41Z

Both plugins are not picked up so at the moment. I am still investigating.

Mic92 · 2018-05-25T08:26:07Z

Ah, I did not check, what we got before.

Mic92 · 2018-05-25T08:30:14Z

Turns out both packages are empty at the moment.

Mic92 · 2018-05-25T09:51:33Z

Fixed.

Mic92 · 2018-05-25T10:02:00Z

@GrahamcOfBorg build python.pkgs.python-language-server python3.pkgs.python-language-server
python3.pkgs.pyls-mypy python3.pkgs.pyls-isort

GrahamcOfBorg · 2018-05-25T10:02:49Z

Success on x86_64-darwin (full log)

Attempted: python.pkgs.python-language-server, python3.pkgs.python-language-server

Partial log (click to expand)

test/test_uris.py                          17      2    88%
test/test_utils.py                         56      0   100%
/nix/store/9x01k2w0m29sz605ajdw7vk3g77rs76z-python2.7-python-language-server-0.18.0
/nix/store/d3hmqissvkh4sxxvnm5wms3b9lr3ry2z-python3.6-python-language-server-0.18.0
test/test_workspace.py                     33      0   100%
-----------------------------------------------------------
TOTAL                                    2051    219    89%
Coverage HTML written to dir htmlcov

===================== 89 passed, 5 skipped in 4.80 seconds =====================

GrahamcOfBorg · 2018-05-25T10:06:20Z

Success on aarch64-linux (full log)

Attempted: python.pkgs.python-language-server, python3.pkgs.python-language-server

Partial log (click to expand)

test/test_uris.py                          17      2    88%
test/test_utils.py                         56      0   100%
test/test_workspace.py                     33      0   100%
-----------------------------------------------------------
TOTAL                                    2051    219    89%
Coverage HTML written to dir htmlcov

==================== 89 passed, 5 skipped in 22.57 seconds =====================
/nix/store/w1ibly0xybglnvjz81xifrsxjy8rmnin-python2.7-python-language-server-0.18.0
/nix/store/mygidsqwij3hs3l9jiivvpdgfn36sldn-python3.6-python-language-server-0.18.0

GrahamcOfBorg · 2018-05-25T10:08:50Z

Success on x86_64-linux (full log)

Attempted: python.pkgs.python-language-server, python3.pkgs.python-language-server

Partial log (click to expand)

test/test_uris.py                          17      2    88%
test/test_utils.py                         56      0   100%
test/test_workspace.py                     33      0   100%
-----------------------------------------------------------
TOTAL                                    2051    219    89%
Coverage HTML written to dir htmlcov

===================== 89 passed, 5 skipped in 6.71 seconds =====================
/nix/store/xb3hx7kns3sfnv447m8jilsyygfghcli-python2.7-python-language-server-0.18.0
/nix/store/hk8xkdqj3fcjjzklz9qmbw67slx5ipg9-python3.6-python-language-server-0.18.0

GrahamcOfBorg · 2018-05-25T10:13:13Z

Success on x86_64-linux (full log)

Attempted: mypy

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yml98fqhs57yv4cpqhmzxm29mqapzwym-python3.6-mypy-0.600/lib  /nix/store/yml98fqhs57yv4cpqhmzxm29mqapzwym-python3.6-mypy-0.600/bin
patching script interpreter paths in /nix/store/yml98fqhs57yv4cpqhmzxm29mqapzwym-python3.6-mypy-0.600
/nix/store/yml98fqhs57yv4cpqhmzxm29mqapzwym-python3.6-mypy-0.600/lib/mypy/typeshed/tests/mypy_test.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/96wn2gz3mwi71gwcrvpfg39bsymd7gqx-python3-3.6.5/bin/python3"
/nix/store/yml98fqhs57yv4cpqhmzxm29mqapzwym-python3.6-mypy-0.600/lib/mypy/typeshed/tests/mypy_selftest.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/96wn2gz3mwi71gwcrvpfg39bsymd7gqx-python3-3.6.5/bin/python3"
/nix/store/yml98fqhs57yv4cpqhmzxm29mqapzwym-python3.6-mypy-0.600/lib/mypy/typeshed/tests/pytype_test.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/96wn2gz3mwi71gwcrvpfg39bsymd7gqx-python3-3.6.5/bin/python"
checking for references to /build in /nix/store/yml98fqhs57yv4cpqhmzxm29mqapzwym-python3.6-mypy-0.600...
wrapping `/nix/store/yml98fqhs57yv4cpqhmzxm29mqapzwym-python3.6-mypy-0.600/bin/dmypy'...
wrapping `/nix/store/yml98fqhs57yv4cpqhmzxm29mqapzwym-python3.6-mypy-0.600/bin/stubgen'...
wrapping `/nix/store/yml98fqhs57yv4cpqhmzxm29mqapzwym-python3.6-mypy-0.600/bin/mypy'...

GrahamcOfBorg · 2018-05-25T10:13:15Z

Success on x86_64-darwin (full log)

Attempted: mypy

Partial log (click to expand)

post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/icg5a777kh9afsrx1ij3n4cq5bq76zvm-python3.6-mypy-0.600/lib  /nix/store/icg5a777kh9afsrx1ij3n4cq5bq76zvm-python3.6-mypy-0.600/bin
patching script interpreter paths in /nix/store/icg5a777kh9afsrx1ij3n4cq5bq76zvm-python3.6-mypy-0.600
/nix/store/icg5a777kh9afsrx1ij3n4cq5bq76zvm-python3.6-mypy-0.600/lib/mypy/typeshed/tests/mypy_selftest.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/sm6n6vgc3gy064nnvc49b5g8a6n2cn8h-python3-3.6.5/bin/python3"
/nix/store/icg5a777kh9afsrx1ij3n4cq5bq76zvm-python3.6-mypy-0.600/lib/mypy/typeshed/tests/mypy_test.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/sm6n6vgc3gy064nnvc49b5g8a6n2cn8h-python3-3.6.5/bin/python3"
/nix/store/icg5a777kh9afsrx1ij3n4cq5bq76zvm-python3.6-mypy-0.600/lib/mypy/typeshed/tests/pytype_test.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/sm6n6vgc3gy064nnvc49b5g8a6n2cn8h-python3-3.6.5/bin/python"
wrapping `/nix/store/icg5a777kh9afsrx1ij3n4cq5bq76zvm-python3.6-mypy-0.600/bin/dmypy'...
wrapping `/nix/store/icg5a777kh9afsrx1ij3n4cq5bq76zvm-python3.6-mypy-0.600/bin/mypy'...
wrapping `/nix/store/icg5a777kh9afsrx1ij3n4cq5bq76zvm-python3.6-mypy-0.600/bin/stubgen'...

GrahamcOfBorg · 2018-05-25T10:13:26Z

Success on aarch64-linux (full log)

Attempted: mypy

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/6qyg340bb2xs8jwb261n88gwivx81kip-python3.6-mypy-0.600/lib  /nix/store/6qyg340bb2xs8jwb261n88gwivx81kip-python3.6-mypy-0.600/bin
patching script interpreter paths in /nix/store/6qyg340bb2xs8jwb261n88gwivx81kip-python3.6-mypy-0.600
/nix/store/6qyg340bb2xs8jwb261n88gwivx81kip-python3.6-mypy-0.600/lib/mypy/typeshed/tests/mypy_selftest.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/qdcj04rnk8kb34zjrfzg8gfgl6svfcr8-python3-3.6.5/bin/python3"
/nix/store/6qyg340bb2xs8jwb261n88gwivx81kip-python3.6-mypy-0.600/lib/mypy/typeshed/tests/mypy_test.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/qdcj04rnk8kb34zjrfzg8gfgl6svfcr8-python3-3.6.5/bin/python3"
/nix/store/6qyg340bb2xs8jwb261n88gwivx81kip-python3.6-mypy-0.600/lib/mypy/typeshed/tests/pytype_test.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/qdcj04rnk8kb34zjrfzg8gfgl6svfcr8-python3-3.6.5/bin/python"
checking for references to /build in /nix/store/6qyg340bb2xs8jwb261n88gwivx81kip-python3.6-mypy-0.600...
wrapping `/nix/store/6qyg340bb2xs8jwb261n88gwivx81kip-python3.6-mypy-0.600/bin/stubgen'...
wrapping `/nix/store/6qyg340bb2xs8jwb261n88gwivx81kip-python3.6-mypy-0.600/bin/mypy'...
wrapping `/nix/store/6qyg340bb2xs8jwb261n88gwivx81kip-python3.6-mypy-0.600/bin/dmypy'...
/nix/store/6qyg340bb2xs8jwb261n88gwivx81kip-python3.6-mypy-0.600

Mic92 · 2018-05-25T10:44:07Z

Also added in the wiki: https://nixos.wiki/wiki/Vim#Vim_as_a_Python_IDE

Mic92 requested a review from FRidh as a code owner May 24, 2018 23:32

Mic92 changed the title ~~Python language server~~ python.pkgs.python-language-server: init at 0.18.0 May 24, 2018

GrahamcOfBorg added the 6.topic: python label May 24, 2018

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels May 24, 2018

teto mentioned this pull request May 25, 2018

[WIP] Python language server provider #31180

Closed

8 tasks

Mic92 added the 2.status: work-in-progress label May 25, 2018

Mic92 force-pushed the python-language-server branch from f4afd88 to 436c395 Compare May 25, 2018 09:51

Mic92 removed the 2.status: work-in-progress label May 25, 2018

Mic92 force-pushed the python-language-server branch from 436c395 to 54430dc Compare May 25, 2018 09:59

Mic92 added 7 commits May 25, 2018 10:59

python.pkgs.parso: 0.1.1 -> 0.2.0

53d7fe7

python.pkgs.jedi: 0.11.1 -> 0.12.0

1a1799b

mypy: make it usuable as a library

b76177a

python.pkgs.pyls-mypy: init at 0.1.2

d4153a6

python.pkgs.pyls-isort: init at 0.1.2

5432e4d

python.pkgs.spyder: fix setup.py patch

f7650eb

python.pkgs.python-language-server: init at 0.18.0

88b94b7

Mic92 force-pushed the python-language-server branch from 54430dc to 88b94b7 Compare May 25, 2018 10:00

Mic92 merged commit dccd2e9 into NixOS:master May 25, 2018

Mic92 deleted the python-language-server branch May 25, 2018 10:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python.pkgs.python-language-server: init at 0.18.0 #41061

python.pkgs.python-language-server: init at 0.18.0 #41061

Mic92 commented May 24, 2018 •

edited

Mic92 commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

teto commented May 25, 2018

Mic92 commented May 25, 2018

Mic92 commented May 25, 2018

Mic92 commented May 25, 2018

Mic92 commented May 25, 2018

Mic92 commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

Mic92 commented May 25, 2018

python.pkgs.python-language-server: init at 0.18.0 #41061

python.pkgs.python-language-server: init at 0.18.0 #41061

Conversation

Mic92 commented May 24, 2018 • edited

Motivation for this change

Things done

Mic92 commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

GrahamcOfBorg commented May 24, 2018

teto commented May 25, 2018

Mic92 commented May 25, 2018

Mic92 commented May 25, 2018

Mic92 commented May 25, 2018

Mic92 commented May 25, 2018

Mic92 commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

GrahamcOfBorg commented May 25, 2018

Mic92 commented May 25, 2018

Mic92 commented May 24, 2018 •

edited