nixos/duplicati: add port and datafolder options #41057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having configuration options is always a good idea of course, but isn't the datafolder just used for storing the internal state in which it really doesn't matter where it goes, no? While you're at it, please make the interface on which it listens configurable instead of the current |
|
@peterhoeg Thanks for the review. You are right the datafolder is only used to store the state of the backups so it could be hardcoded as it would not be a big deal. |
nyanloutre
force-pushed
the
duplicati/custom_options
branch
3 times, most recently
from
467859d
to
7e6c4c5
Compare
|
In the name of security, how about changing the default interface to localhost and make a note in the description about setting it back to |
nyanloutre
force-pushed
the
duplicati/custom_options
branch
from
7e6c4c5
to
20f6c5c
Compare
|
@peterhoeg done ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add some modularity to the duplicati module.
It's now possible to specify the port duplicaty is listening on with
services.duplicati.portand the datafolder withservices.duplicati.datafolder.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)